Fix file lookup documented and actual return types #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, file was reported to return `GenericHelperFn`, when it in fact would return either `GenericHelperFn` or `Base64`. Updated the docstring to reflect their common base class instead. Also updated the function to fix a regression where a string was sometimes being returned instead. Fixes cloudtools#645
phobologic
approved these changes
Aug 12, 2018
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
Previously, file was reported to return `GenericHelperFn`, when it in fact would return either `GenericHelperFn` or `Base64`. Updated the docstring to reflect their common base class instead. Also updated the function to fix a regression where a string was sometimes being returned instead. Fixes cloudtools#645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, file was reported to return
GenericHelperFn, when it in fact would return eitherGenericHelperFnorBase64. Updated the docstring to reflect their common base class instead.Also updated the function to fix a regression where a string was sometimes being returned instead.
Fixes #645