Locked stacks have no dependencies #661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance optimization when using the
--stacks/--targets
flag, and extracted from #632.Think of the following example
This forms a dependency graph like so:
Given I run
stacker build --targets c
, stacker will walk all 3 nodes in the graph, however, given thatb
is locked, it's unnecessary for stacker to executea
; sinceb
is locked it doesn't need any information froma
, and thus, doesn't actually depend ona
.With this change, because
b
is locked, it has no dependencies, soa
will not be included in the filtered graph, which becomes: