Add YAML environment file support #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment files ending in .yaml or .yml will be rendered using a different strategy. The env file is treated as a dict, with the value for each key being a parsed YAML object. After parsing the config, we look for things that look like variable references, and replace the references with objects.
Now with the correct version of flake8
Moto is requiring policy documents to be at least version 2012-10-17, so add that property.
Python 2.7 strings and Python 3 strings work differently, and regular expression matching is different too. Rewrite in a way which works with both language versions.
Moto is requiring policy documents to be at least version 2012-10-17, so add that property.
When checking for yaml suffixes on environment files, ignore case.
Environment files ending in .yaml or .yml will be rendered using a different strategy. The env file is treated as a dict, with the value for each key being a parsed YAML object. After parsing the config, we look for things that look like variable references, and replace the references with objects.
Now with the correct version of flake8
Python 2.7 strings and Python 3 strings work differently, and regular expression matching is different too. Rewrite in a way which works with both language versions.
When checking for yaml suffixes on environment files, ignore case.
|
When this is merged will we be able to define list object and lists of objects in these yaml files for parsing later on? |
sd0408
reviewed
Aug 14, 2019
docs/environments.rst
Outdated
| We've defined a stack which expects a list of ingress CIDR's allowed access to | ||
| each port. Our environment files would look like this:: | ||
|
|
||
| # in the file: stage.env |
There was a problem hiding this comment.
shouldn't this doc state stage.yml and not stage.env?
There was a problem hiding this comment.
Yup, will update shortly!
Yaml config example should use .yml file suffix, not .env
|
So, guys, what's the verdict on this PR? |
|
Any thoughts on merging this? |
phobologic
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
This is great, thanks @mromaszewicz - and sorry for the delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment files ending in .yaml or .yml will be rendered using
a different strategy. The env file is treated as a dict, with
the value for each key being a parsed YAML object. After parsing
the config, we look for things that look like variable references,
and replace the references with objects.