Ensure that base64 lookup codec encodes the bytes object as a string #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellballestrini
approved these changes
Aug 15, 2019
|
@acmcelwee could you update https://github.com/cloudtools/stacker/blob/master/CHANGELOG.md ? |
acmcelwee
force-pushed
the
base64-lookup-decode
branch
from
98fc0c1
to
8827324
Compare
|
@russellballestrini, thanks for the read. I added a changelog entry (with a force push to keep the commit history clean). I'll let you give it a final look before I merge it, or also feel free to merge it yourself, if it looks good to you. |
|
Looks good to me! Merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently updated our python runtime for stacker from 2 to 3, and using the
filelookup with thebase64codec results in the output being a bytes object (b'foo...'), instead of a string that's usable as a CFN parameter or even a local stacker variable.Fixes #693.