-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support partitioned cookies #1041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haswf
commented
Jan 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1041 +/- ##
===========================================
+ Coverage 82.49% 82.54% +0.04%
===========================================
Files 98 98
Lines 10011 10024 +13
===========================================
+ Hits 8259 8274 +15
+ Misses 1255 1254 -1
+ Partials 497 496 -1 ☔ View full report in Codecov by Sentry. |
Haswf
changed the title
feat(cookie): support partitioned cookies (CHIPS)
feat: support partitioned cookies
Jan 9, 2024
welkeyever
reviewed
Jan 11, 2024
welkeyever
reviewed
Jan 11, 2024
welkeyever
reviewed
Jan 11, 2024
welkeyever
reviewed
Jan 11, 2024
welkeyever
reviewed
Jan 11, 2024
welkeyever
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx~
FGYFFFF
approved these changes
Jan 12, 2024
Duslia
approved these changes
Jan 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
feat(cookie): 支持独立分区 Cookies (CHIPS)
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
Chrome has started restricting third-party cookies by default for 1% of Chrome browsers, which means third-party cookies with the SameSite=None attribute will be blocked. Partitioned cookies has been introduced as a privacy preserving alternative. A partitioned cookie is tied to the top-level site where it's initially set and cannot be accessed from elsewhere.
You can learn more about CHIPS here or try the demo.
The net/http library has adopted partitioned cookies with golang/go#62490 and #1032.
To support partitioned cookies for Hertz, the following changes have been made:
partitioned
field to CookiePartitioned;
to the end of the cookie if partitioned is set to true.Partitioned
andSetPartitioned
to get and set partitioned. SetPartitioned to true, will also set Secure.zh(optional):
(Optional) Which issue(s) this PR fixes:
Fixes #1032
(Optional) The PR that updates user documentation:
No