Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: optimize for thriftgo sdk #206

Merged
merged 3 commits into from
May 30, 2024
Merged

optimize: optimize for thriftgo sdk #206

merged 3 commits into from
May 30, 2024

Conversation

HeyJavaBean
Copy link
Member

@HeyJavaBean HeyJavaBean commented May 30, 2024 •
edited
Loading

Description

optimize for thriftgo sdk, since there're some cases the previous pr can't handle well.

  1. support 「help」and 「version」for sdk call and return instead of os.Exit
  2. optimize public struct ref logic for idl path matcher.

Motivation and Context

Related Issue

@HeyJavaBean HeyJavaBean requested review from a team as code owners May 30, 2024 06:08
@HeyJavaBean HeyJavaBean merged commit 6600bc0 into cloudwego:main May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FGYFFFF FGYFFFF FGYFFFF approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeyJavaBean @FGYFFFF