Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Installing offline package and customization during the image build procedure #31

Merged
merged 3 commits into from
Apr 16, 2023

Conversation

meraj-kashi
Copy link
Contributor

According to #30 , I have added a new switch to support running a bash script during image building procedure.

The new feature can be used to install debian packages during build, so the final image doesn't need access to Internet to install packages.

Also the offline-script can be used to do more customization during build.

I hope this feature would be useful to merge :)

@cloudymax
Copy link
Owner

Hoi @meraj-kashi! 👋

First of all, thank you very much for this. It's a feature I've wanted to add for a while but have not had the time to implement due to obligations at work. I'm very much looking forward to testing this and getting it merged but wont have the time until this weekend/next week. I just wanted to extend the courtesy of letting you know that I've seen the request, think that it is a great addition, and will be testing/merging it soon.

Best regards and many thanks!

Copy link
Owner

@cloudymax cloudymax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

This not only adds a very helpful feature but also serves as a great way to connect PXEless to other tooling such as Ansible! I'm really looking forward to playing with this functionality more this week 🥳

@cloudymax cloudymax merged commit d54ae66 into cloudymax:develop Apr 16, 2023
@agusserraa98
Copy link

What a great contribution, I have been following the repo and every day it is a more powerful tool! Thank you very much for sharing your knowledge!

@cloudymax
Copy link
Owner

What a great contribution, I have been following the repo and every day it is a more powerful tool! Thank you very much for sharing your knowledge!

Thanks for your kind words, I'm honestly humbled by the amount and quality of community engagement. The original project from covertsh was super helpful for me in a previous role and it's been a true privilege to help keep the project going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants