Fix search persistence #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloverich
force-pushed
the
fix-search-persistence
branch
from
e80415c to
abc280d
Compare
cloverich
commented
Feb 14, 2024
| const [searchStore, setSearchStore] = useState<null | SearchStore>(null); | ||
|
|
||
| // This is more like an effect. This smells. Maybe just roll this all up into | ||
| // a hook. |
There was a problem hiding this comment.
Probably should remove this (copied from container); this component is sufficiently special purpose.
- fix search persistence when navigating in and out of notes, if search was not initiated by pagination (i.e. sidebar). Caused by setSearch not updating the URL. Fixing that revealed a loop, and required refactoring to use the route tree to control which components have access to the search store - refactor TagSearchStore -> SearchParser; make it stateless and move stateful handling to SearchStore
cloverich
force-pushed
the
fix-search-persistence
branch
from
abc280d to
3a511b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix search persistence when navigating in and out of notes, if search was not initiated by pagination (i.e. sidebar). Caused by setSearch not updating the URL. Fixing that revealed a loop, and required refactoring to use the route tree to control which components have access to the search store
Notably, in #150 I called this a bug and asked how it broke. It was actually never implemented -- search persistence was only partially implemented. This finishes the implementation, and also improves the design in that components requiring the persistent store all receive it from a shared ancestor (route); removes the need for a couple hacks.
Closes #150