Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for valid package URL #117

Merged

Conversation

icedream
Copy link
Contributor

This regex pattern used to accept some package names, those include:

  • Package names without dashes
  • Packages with version ranges

Respective examples have been added to the existing test.

Fixes #101.

This regex pattern used to accept some package names, those include:

- Package names without dashes
- Packages with version ranges

Respective examples have been added to the existing test.

Fixes clue#101.
@clue clue added this to the v1.3.0 milestone Dec 28, 2021
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icedream Thank you for looking into this, changes LGTM! :shipit:

Keep it up! 👍

@clue clue merged commit 6907aa2 into clue:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not accept version ranges when building external packages
2 participants