Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually exclude the vendor dir #38

Merged
merged 2 commits into from
Nov 14, 2015
Merged

Actually exclude the vendor dir #38

merged 2 commits into from
Nov 14, 2015

Conversation

radford
Copy link
Contributor

@radford radford commented Jul 27, 2014

This avoids including the entire vendor directory twice which greatly speeds up phar generation.

@radford
Copy link
Contributor Author

radford commented Jul 28, 2014

This might be better done by getting $this->package['config']['vendor-dir'] directly or by adding a getPathVendorRelative() which does that.

@radford
Copy link
Contributor Author

radford commented Jul 28, 2014

I went ahead an implemented getPathVendorRelative() and pushed it. the combined patch looks much better. I'd happy to squash these if you'd prefer that.

@clue
Copy link
Owner

clue commented Jun 6, 2015

Awesome, I'd love to get this in! 👍 Can you add a test case to confirm this doesn't break anything?

@clue clue mentioned this pull request Jun 6, 2015
@radford
Copy link
Contributor Author

radford commented Jun 9, 2015

Looks like I forgot to actually commit my change to add getPathVendorRelative(). I pushed that and rebased the fix on top of it.

@clue
Copy link
Owner

clue commented Jun 18, 2015

Thanks for the update, the code looks good to me! 👍 Can you add some tests?

The CI setup is currently broken (see #49), so I'll have to postpone merging this for now.

@clue
Copy link
Owner

clue commented Nov 14, 2015

I'm currently in the process of reviewing this and I'm testing several approaches to reducing the build time.

Just for the reference, this PR alone brings the build time for composer/composer from 340s down to 150s.

clue added a commit that referenced this pull request Nov 14, 2015
Actually exclude the vendor dir
@clue clue merged commit 9f84efe into clue:master Nov 14, 2015
@clue
Copy link
Owner

clue commented Nov 14, 2015

Thanks for your effort and your patience @radford! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants