Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize JSON in a way that doesn't require duplicate calculations of Document hashes #789

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

kwalcock
Copy link
Member

This is coordinated with changes in processors and can only be used after processors is updated.

Uses of implicits and package files have been removed.
Much duplicated code has been removed.
Document hashes are stored temporarily and reused.
Several related issues have been filed.
TODOs have been added near problematic code.

The new output matches previous output except that roots are sorted and triggers get their actual class and not the generic TextBoundMention. All tests showed IDs being equal to their previous values, even when those values are problematic. Those fixes are scheduled for later.

There is still some debug output for timing that needs to be removed after further testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant