-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ulduar: Convert Iron Council to BossAI and Spell Lists #431
base: master
Are you sure you want to change the base?
Conversation
caster->CastSpell(nullptr, SPELL_TENDRILS_VISUAL, TRIGGERED_OLD_TRIGGERED); | ||
DoBroadcastText(SAY_BRUNDIR_FLY, caster); | ||
caster->SetHover(true); | ||
caster->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_STUNNED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already handled by the visual effect
actually requires
caster->SetByteValue(UNIT_FIELD_BYTES_1, UNIT_BYTES_1_OFFSET_MISC_FLAGS, UNIT_BYTE1_FLAG_FLY_ANIM);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the flag is in sniff, then add it in script.
if (m_pInstance) | ||
m_pInstance->SetData(TYPE_ASSEMBLY, SPECIAL); | ||
} | ||
struct LightningTendrils : public SpellScript, public AuraScript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be redone
63486 is casted and hover flag is immediately set, then after 3 ticks (3 seconds) SMSG_ON_MONSTER_MOVE is sent for the hovering waypoint
3 ticks before the aura ends SMSG_MONSTER_MOVE is set for the floor
once the aura disappears the hover flag is immediately unset.
the aura is present for 24 ticks
SetSpecialAchievementCriteria(TYPE_ACHIEV_STEELBREAKER, true); | ||
switch (urand(0,2)) | ||
{ | ||
case 0: if(Unit* brundir = GetSingleCreatureFromStorage(NPC_BRUNDIR)) DoBroadcastText(34314, brundir); break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add these texts to enum
m_pInstance->SetData(TYPE_ASSEMBLY, IN_PROGRESS); | ||
BossAI::Aggro(); | ||
if (m_instance) | ||
m_instance->SetData(TYPE_ASSEMBLY, IN_PROGRESS); | ||
|
||
m_creature->InterruptNonMeleeSpells(false); | ||
DoCastSpellIfCan(m_creature, SPELL_BERSERK, CAST_TRIGGERED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure the berserk spell has self as target in spell data
Each mob needs 3 spell lists for each level of empowerment. Each phase gives them one additional ability and when they get empowered, the spell lists need to be switched in script. |
I didn't give them separate spell lists because I made the spell impossible to cast if they don't have a set number of auras. Are you sure it's done with separate spell lists? |
Simple, even if spell cast doesnt go through, cooldown still ticks, the empower 1 phase spell for lets say molgheim would go through immediately on him gaining aura empowerment stack 1. Cooldown needs to start in the moment of his empowerment, and that implies him swapping spell lists on moment of empowerment. |
🍰 Pullrequest
This PR converts the Iron Council to BossAI + Spell Lists
Todo / Checklist