Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename function #22

Merged
merged 13 commits into from
Dec 7, 2021
Merged

Rename function #22

merged 13 commits into from
Dec 7, 2021

Conversation

gwenwhite
Copy link
Contributor

Changed snap_molecule_cluster to get_molecule_cluster to resolve issue #13

Copy link
Contributor

@erjank erjank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update deprecated calls to "snap_molecule_cluster" in structure.py and test_gsd.py

Copy link
Member

@jennyfothergill jennyfothergill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I see one more instance to change in cmeutils/structure.py on line 167

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #22 (ceaaa2d) into master (adb1764) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files           5        5           
  Lines         224      224           
=======================================
  Hits          223      223           
  Misses          1        1           
Impacted Files Coverage Δ
cmeutils/gsd_utils.py 100.00% <100.00%> (ø)
cmeutils/structure.py 100.00% <100.00%> (ø)

Copy link
Member

@jennyfothergill jennyfothergill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@erjank erjank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@erjank erjank merged commit 6a90d3e into cmelab:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename snap_molecule_cluster since the input isn’t always a snap
4 participants