-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename function #22
Rename function #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update deprecated calls to "snap_molecule_cluster" in structure.py and test_gsd.py
Rename function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I see one more instance to change in cmeutils/structure.py
on line 167
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 5 5
Lines 224 224
=======================================
Hits 223 223
Misses 1 1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Changed snap_molecule_cluster to get_molecule_cluster to resolve issue #13