Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chris suggested this PR for plotting this 3d heat map type plot. #34

Merged
merged 5 commits into from
Feb 24, 2022

Conversation

JimmyRushing
Copy link
Contributor

This function computes a nice 3d color-coded scatter plot from three lists of numbers.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #34 (df53cfc) into master (8e33350) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   99.67%   99.68%   +0.01%     
==========================================
  Files           7        7              
  Lines         308      318      +10     
==========================================
+ Hits          307      317      +10     
  Misses          1        1              
Impacted Files Coverage Δ
cmeutils/plotting.py 100.00% <100.00%> (ø)

Copy link
Member

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! So far so good. I've left some comments.

cmeutils/plotting.py Outdated Show resolved Hide resolved
cmeutils/plotting.py Outdated Show resolved Hide resolved
cmeutils/plotting.py Outdated Show resolved Hide resolved
cmeutils/plotting.py Outdated Show resolved Hide resolved
@chrisjonesBSU
Copy link
Member

Thanks for making those changes. A couple more things:

  1. You should write a unit test. There's not much to test here, so at minimum you could make a unit test that just calls the function. That way if there is an error the unit test fails.
  2. github is telling us there are conflicts that need to be handled before this can be merged. You can merge upstream master into your branch and fix the conflicts in vim.

@chrisjonesBSU chrisjonesBSU merged commit e96dd7f into cmelab:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants