Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hoomd import inside rigid body function #80

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

chrisjonesBSU
Copy link
Member

This is a small change that moves the hoomd import from the top of gsd_utils.py into the create_rigid_snapshot method, which is the only place it is used.

Importing and using other cmeutils methods was causing issues on clusters when my environment had the gpu-version of hoomd, but the job wasn't on a gpu node.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dca592a) 96.28% compared to head (42d639f) 96.28%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files           8        8           
  Lines         781      781           
=======================================
  Hits          752      752           
  Misses         29       29           
Files Coverage Δ
cmeutils/gsd_utils.py 91.66% <100.00%> (ø)

@chrisjonesBSU chrisjonesBSU merged commit 6a68c97 into cmelab:master Feb 16, 2024
4 checks passed
@chrisjonesBSU chrisjonesBSU deleted the fix-hoomd-import branch February 16, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant