Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for freud 3.0 #93

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

chrisjonesBSU
Copy link
Member

@chrisjonesBSU chrisjonesBSU commented Jun 4, 2024

This PR fixes the breaking change in freud 3.0 (See #81). I also updated __version__.py to match the last release.

@chrisjonesBSU
Copy link
Member Author

I still need to make sure the vectors are accounting for PBCs

@chrisjonesBSU chrisjonesBSU added bug Something isn't working and removed bug Something isn't working labels Jun 5, 2024
@chrisjonesBSU
Copy link
Member Author

Ok, should be ready to go. I want to test this out with GRiTS before merging, since the only change is to the cluster function.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (3419258) to head (3f099cc).
Report is 6 commits behind head on master.

Current head 3f099cc differs from pull request most recent head c563b7f

Please upload reports for the commit c563b7f to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   96.33%   96.35%   +0.02%     
==========================================
  Files           8        8              
  Lines         791      796       +5     
==========================================
+ Hits          762      767       +5     
  Misses         29       29              
Files Coverage Δ
cmeutils/gsd_utils.py 91.70% <100.00%> (+0.03%) ⬆️

@chrisjonesBSU chrisjonesBSU merged commit 7d00de9 into cmelab:master Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant