-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including testing tutorial notebooks in PR unit CI workflow #127
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Ok, I added MacOS to the os matrix now. Also, I made a separate jobs for testing the tutorials. I don't think we need to test the tutorials on every os + python version combo. Also, it should be set up so that the tutorial test has to be trigged manually with a comment in the PR. My thinking is that we can run that check once a PR is nearly finished, rather than having it run after every commit. |
run-test-tutorials |
run-test-tutorials |
1 similar comment
run-test-tutorials |
/testtutorials |
Hmm..I can't figure out how to trigger the |
/testtutorials |
/testtutorials |
/testtutorials |
/testtutorials |
testtutorials |
/testtutorials |
Ok, we're merging this as is for now. After talking with @marjanalbooyeh we are going to get a workflow set up to run test on notebooks locally or on clusters. |
This PR adds
nbmake
toenvironment-dev.yml
and adds an action for testing the tutorial notebooks anytime a PR is made.The addition of this workflow and use of
nbmake
seems to be working as intended, but some of the notebooks have errors. I'll work on fixing those in this same PR.