Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Lattice box and Tensile simulation. Add more unit tests #29

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Fix for Lattice box and Tensile simulation. Add more unit tests #29

merged 6 commits into from
Aug 25, 2023

Conversation

chrisjonesBSU
Copy link
Member

@chrisjonesBSU chrisjonesBSU commented Aug 25, 2023

While adding unit tests for the welding and tensile simulations I ran into a couple issues.

  1. The box wasn't being set in a way that avoids overlapping particles along the boundaries. Now, the box lengths are longer in each direction by one lattice constant, and by a small amount (3 angstrom) in the z direction.

  2. I fixed a couple issues with the tensile simulation class.

Copy link
Collaborator

@marjanalbooyeh marjanalbooyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #29 (9957b9b) into main (c5dd6e7) will increase coverage by 4.52%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   84.65%   89.17%   +4.52%     
==========================================
  Files          18       18              
  Lines        1303     1303              
==========================================
+ Hits         1103     1162      +59     
+ Misses        200      141      -59     
Files Changed Coverage Δ
hoomd_organics/base/system.py 81.92% <100.00%> (+0.22%) ⬆️
hoomd_organics/library/simulations/tensile.py 100.00% <100.00%> (+80.00%) ⬆️

... and 2 files with indirect coverage changes

@chrisjonesBSU chrisjonesBSU merged commit ca8ac13 into cmelab:main Aug 25, 2023
4 checks passed
@chrisjonesBSU chrisjonesBSU mentioned this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants