Fix mismatched gmso residue name when molecule is loaded from mol2 #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the gmso topology parameterization issue caused by name mismatch in mbuild compound.
For a Molecule loaded from a mol2 file, if we change the mbuild compound name, the name of its children does not change accordingly. When the forcefield dictionary with keys similar to the compound name is being applied to the system, the gmso topology is not parameterized because of this naming mismach.
As a quick fix, this PR makes sure that the name is assigned to every child of the mbuild compound. However, more investigation needs to be done on gmso's behavior when converting an mbuild compound to a topology. (see the example in the comments).