Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add write_at_start parameters to run functions #46

Merged
merged 2 commits into from
Sep 15, 2023
Merged

add write_at_start parameters to run functions #46

merged 2 commits into from
Sep 15, 2023

Conversation

chrisjonesBSU
Copy link
Member

This is a quick PR that adds a parameter to the run functions called write_at_start This is the same parameter that is in hoomd.Simulation.run(), we're just passing along the parameter. One difference is that we change the default value from False to True

@chrisjonesBSU chrisjonesBSU linked an issue Sep 15, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #46 (d25b69e) into main (15fd092) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          18       18           
  Lines        1347     1347           
=======================================
  Hits         1264     1264           
  Misses         83       83           
Files Changed Coverage Δ
hoomd_organics/base/simulation.py 91.96% <100.00%> (ø)

Copy link
Collaborator

@marjanalbooyeh marjanalbooyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisjonesBSU chrisjonesBSU merged commit 96809e9 into cmelab:main Sep 15, 2023
3 checks passed
@chrisjonesBSU chrisjonesBSU deleted the write-at-start branch September 15, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add write_at_start to Simulation class
2 participants