Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphene surface to library #67

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Add graphene surface to library #67

merged 5 commits into from
Oct 3, 2023

Conversation

chrisjonesBSU
Copy link
Member

This PR adds a recipe to create a graphene surface to the library. We can use this for creating a surface wetting workflow module.

Copy link
Collaborator

@marjanalbooyeh marjanalbooyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just added a few suggestions for docstring format.

thank you

hoomd_organics/library/surfaces.py Outdated Show resolved Hide resolved
hoomd_organics/library/surfaces.py Outdated Show resolved Hide resolved
hoomd_organics/library/surfaces.py Outdated Show resolved Hide resolved
hoomd_organics/library/surfaces.py Outdated Show resolved Hide resolved
hoomd_organics/library/surfaces.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #67 (d0af69f) into main (265e633) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   93.70%   93.75%   +0.05%     
==========================================
  Files          19       20       +1     
  Lines        1397     1410      +13     
==========================================
+ Hits         1309     1322      +13     
  Misses         88       88              
Files Coverage Δ
hoomd_organics/library/__init__.py 100.00% <100.00%> (ø)
hoomd_organics/library/surfaces.py 100.00% <100.00%> (ø)

@chrisjonesBSU chrisjonesBSU merged commit 133d7d8 into cmelab:main Oct 3, 2023
4 checks passed
@chrisjonesBSU chrisjonesBSU deleted the graphene branch October 3, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants