Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation in Lattice #74

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

chrisjonesBSU
Copy link
Member

I found a box where the translation of the 2nd chain in the unit cell of Lattice was not being translated correctly. This should fix that

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #74 (b03116b) into main (a9269b8) will increase coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head b03116b differs from pull request most recent head 88d4958. Consider uploading reports for the commit 88d4958 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   93.73%   93.86%   +0.12%     
==========================================
  Files          20       20              
  Lines        1533     1531       -2     
==========================================
  Hits         1437     1437              
+ Misses         96       94       -2     
Files Coverage Δ
flowermd/base/system.py 90.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

@chrisjonesBSU chrisjonesBSU merged commit aeb45d5 into cmelab:main Oct 10, 2023
2 checks passed
@chrisjonesBSU chrisjonesBSU deleted the fix-lattice branch October 10, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants