Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEKK, remove random_sequence parameter from CoPolymer #83

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

chrisjonesBSU
Copy link
Member

This PR removes random_sequence as a parameter when initializing a CoPolymer. Instead, random_sequence is set based on what is given for sequence when initializing a CoPolymer

Copy link
Collaborator

@marjanalbooyeh marjanalbooyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #83 (1357ea4) into main (f4bf132) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   93.73%   93.81%   +0.07%     
==========================================
  Files          20       20              
  Lines        1533     1535       +2     
==========================================
+ Hits         1437     1440       +3     
+ Misses         96       95       -1     
Files Coverage Δ
flowermd/base/molecule.py 96.58% <100.00%> (+0.02%) ⬆️
flowermd/library/polymers.py 98.66% <ø> (+1.33%) ⬆️

@chrisjonesBSU chrisjonesBSU merged commit 018fb9e into cmelab:main Oct 25, 2023
4 checks passed
@chrisjonesBSU chrisjonesBSU deleted the pekk branch October 25, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants