Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Aurelia DefinitionTypes to definitely typed :) #34

Open
kristianmandrup opened this issue May 19, 2015 · 18 comments
Open

Please add Aurelia DefinitionTypes to definitely typed :) #34

kristianmandrup opened this issue May 19, 2015 · 18 comments

Comments

@kristianmandrup
Copy link

Would be lovely in we could install Aurelia simply via tsd

https://github.com/DefinitelyTyped/tsd/

What is the reason these DTs are not on http://definitelytyped.org yet?

@cmichaelgraham
Copy link
Owner

no reason - just needs someone to take action :)

@kristianmandrup
Copy link
Author

Already did ;)

https://github.com/kristianmandrup/aurelia-definitely-typed

Would love some more devs from Aurelia community to help push this forward...

@cmichaelgraham
Copy link
Owner

well done, sir 👍 pinging @EisenbergEffect

@kristianmandrup
Copy link
Author

How do you recommend I ping him?

@cmichaelgraham
Copy link
Owner

oh i was just mentioning him in the comment, which sends him an alert. :)

@kristianmandrup
Copy link
Author

@EisenbergEffect I've completed most of the "grunt work" for this effort. Now we just need some core devs (or others) to go through and review/refine the tests and d.ts files. Then we can post to the DefinitelyTyped repo to finally make aurelia modules installable via tds package manager :)

https://github.com/kristianmandrup/aurelia-definitely-typed

@EisenbergEffect
Copy link

@cmichaelgraham Can you review what @kristianmandrup has done and make a recommendation? Note that this is a temp solution, we are likely to start generating the dts file directly from our source in the future and distributing them along with each library release. But, we need something sooner I agree. Let me know.

@kristianmandrup
Copy link
Author

The "problem" is that according to the contribution guidelines on DT, you need a test .ts files for each .d.ts file in order to confirm that a ts file using your definitions can compile as expected in TS. Which is sensible and logical... my effort is mainly the test files and structuring in the required file/folder format ;)
Which is "grunt work"... so generating d.ts files will fit just fine in the future ;)

@cmichaelgraham
Copy link
Owner

I'm on mobile and out of pocket until Tuesday evening. I can look then if needed. I apologize for the delay

@nukefusion
Copy link

Any move forward with this? Would also like to start using Aurelia but TypeScript definitions are a must.

@EisenbergEffect
Copy link

We are working on it now :)
On Jun 13, 2015 8:41 AM, "Matt Bird" notifications@github.com wrote:

Any move forward with this? Would also like to start using Aurelia but
TypeScript definitions are a must.


Reply to this email directly or view it on GitHub
#34 (comment)
.

@laurentiustamate94
Copy link

Any luck with adding Aurelia TypeScript definitions to http://definitelytyped.org/ ?

@kristianmandrup
Copy link
Author

The main issue is generating the file structure required to be compatible with http://definitelytyped.org/, with a test file for each module which "exercises the API" as I understand it.

@pawelpawlow
Copy link

Any news on the this issue?

@cmichaelgraham
Copy link
Owner

@pawelpawlow - are you interested in aurelia .d.ts files in general or hosted at definitely typed?

@pawelpawlow
Copy link

I think, there are two problems with the typings currently. Aurelia releases include .d.ts files, but after each update we need to copy them to the /typings folder of our project - this is the first problem. The other, bigger problem is that some of the provided files are out of sync or invalid. I think definitely typed can be a nice solution for both problems.

@EisenbergEffect
Copy link

It is literally impossible for the provided files to be out of sync. They are generated directly from the source. Also, you should not have to copy your d.ts files. I believe you can configure the tsconfig file to look in your jspm_packages folder. Please correct me if I'm wrong.

@EisenbergEffect
Copy link

It should be noted that this repo isn't an official aurelia repo and doesn't contain the latest d.ts files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants