-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add Aurelia DefinitionTypes to definitely typed :) #34
Comments
no reason - just needs someone to take action :) |
Already did ;) https://github.com/kristianmandrup/aurelia-definitely-typed Would love some more devs from Aurelia community to help push this forward... |
well done, sir 👍 pinging @EisenbergEffect |
How do you recommend I ping him? |
oh i was just mentioning him in the comment, which sends him an alert. :) |
@EisenbergEffect I've completed most of the "grunt work" for this effort. Now we just need some core devs (or others) to go through and review/refine the tests and https://github.com/kristianmandrup/aurelia-definitely-typed |
@cmichaelgraham Can you review what @kristianmandrup has done and make a recommendation? Note that this is a temp solution, we are likely to start generating the dts file directly from our source in the future and distributing them along with each library release. But, we need something sooner I agree. Let me know. |
The "problem" is that according to the contribution guidelines on DT, you need a test |
I'm on mobile and out of pocket until Tuesday evening. I can look then if needed. I apologize for the delay |
Any move forward with this? Would also like to start using Aurelia but TypeScript definitions are a must. |
We are working on it now :)
|
Any luck with adding Aurelia TypeScript definitions to http://definitelytyped.org/ ? |
The main issue is generating the file structure required to be compatible with http://definitelytyped.org/, with a test file for each module which "exercises the API" as I understand it. |
Any news on the this issue? |
@pawelpawlow - are you interested in aurelia .d.ts files in general or hosted at definitely typed? |
I think, there are two problems with the typings currently. Aurelia releases include .d.ts files, but after each update we need to copy them to the /typings folder of our project - this is the first problem. The other, bigger problem is that some of the provided files are out of sync or invalid. I think definitely typed can be a nice solution for both problems. |
It is literally impossible for the provided files to be out of sync. They are generated directly from the source. Also, you should not have to copy your d.ts files. I believe you can configure the tsconfig file to look in your jspm_packages folder. Please correct me if I'm wrong. |
It should be noted that this repo isn't an official aurelia repo and doesn't contain the latest d.ts files. |
Would be lovely in we could install Aurelia simply via tsd
https://github.com/DefinitelyTyped/tsd/
What is the reason these DTs are not on http://definitelytyped.org yet?
The text was updated successfully, but these errors were encountered: