Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix string when no energy is passed #45

Merged
merged 1 commit into from
May 29, 2024
Merged

fix string when no energy is passed #45

merged 1 commit into from
May 29, 2024

Conversation

lenzip
Copy link
Contributor

@lenzip lenzip commented May 27, 2024

This should address issue #44

@lenzip lenzip requested a review from ttedeschi May 27, 2024 07:46
clelange
clelange reviewed May 27, 2024
View reviewed changes
Copy link
Member

@clelange clelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nicer to not have a white space here if no energy is defined since it might just create a white box that potentially overlaps with other objects, which might be confusing?

@lenzip
Copy link
Contributor Author

lenzip commented May 29, 2024

What do you mean, when no energy is set it now sets cms_energy to "" and then it doesn't set lumiText here. Where do you see the white box coming from?

@clelange
Copy link
Member

Sorry, you're right. I parsed the if statement incorrectly.

@clelange clelange merged commit 2326d44 into cms-cat:master May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clelange clelange clelange approved these changes

@ttedeschi ttedeschi Awaiting requested review from ttedeschi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenzip @clelange