-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference documentation #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, I left just a couple of minor comments.
src/cmsstyle/cmsstyle.py
Outdated
@@ -31,6 +46,12 @@ def SetLumi(lumi, unit="fb", round_lumi=False): | |||
|
|||
|
|||
def SetExtraText(text): | |||
""" | |||
Set extra text to be displayed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One could maybe add: Set extra text to be displayed next to "CMS", e.g. "Preliminary".
src/cmsstyle/cmsstyle.py
Outdated
global additionalInfo | ||
additionalInfo = [] | ||
|
||
def AppendAdditionalInfo(text): | ||
""" | ||
Append additional information to be displayed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here, one could provide and example, e.g. a string identifying a region, or its selection.
Thanks, updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me
Based on mkdocs with mkdocs-material theme and mkdocstrings for automated reference generation.
I've added lots of docstrings so that the documentation gets populated.
Will as a next step then finalise registration with readthedocs.
Closes #34