Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference documentation #47

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Add reference documentation #47

merged 3 commits into from
Jun 21, 2024

Conversation

clelange
Copy link
Member

@clelange clelange commented Jun 21, 2024

Based on mkdocs with mkdocs-material theme and mkdocstrings for automated reference generation.
I've added lots of docstrings so that the documentation gets populated.

Will as a next step then finalise registration with readthedocs.

Closes #34

@clelange clelange added the documentation Improvements or additions to documentation label Jun 21, 2024
Copy link
Contributor

@lenzip lenzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I left just a couple of minor comments.

@@ -31,6 +46,12 @@ def SetLumi(lumi, unit="fb", round_lumi=False):


def SetExtraText(text):
"""
Set extra text to be displayed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could maybe add: Set extra text to be displayed next to "CMS", e.g. "Preliminary".

global additionalInfo
additionalInfo = []

def AppendAdditionalInfo(text):
"""
Append additional information to be displayed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here, one could provide and example, e.g. a string identifying a region, or its selection.

@clelange
Copy link
Member Author

Thanks, updated

Copy link
Contributor

@ttedeschi ttedeschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me

@lenzip lenzip merged commit 0994953 into master Jun 21, 2024
@clelange clelange deleted the readthedocs branch June 21, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add library documentation
3 participants