use ReadPrescalesFromFile=False in the GenericTriggerEventFlag of a bunch of DQM modules

[mmusich]

PR description:

Spinned off from #46448 (comment).
Reading L1T prescales from an 8 years old file looks wrong. Should help mitigating #46448.

PR validation:

None, other than compiling

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will be backported to active data-taking cycles if validates OK

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46530/42393

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• DQM/SiStripMonitorClient (dqm)
• DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @arossi83, @cericeci, @fioriNTU, @idebruyn, @jandrea, @jhgoh, @missirol, @mtosi, @rociovilar, @sroychow, @threus, @trocino, @venturia this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ef7ed/42424/summary.html
COMMIT: bd212af
CMSSW: CMSSW_14_2_X_2024-10-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46530/42424/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3569177
• DQMHistoTests: Total failures: 388
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3568769
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 201 log files, 171 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[mmusich]

Removing RFC, as form the tests there seems to be no obvious downsides.

[antoniovagnerini]

+1

• spurious differences from HGCal DQM test (open issue Non reproducibility in HGCal DQM #46416)
• P5 tests OK

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[makortel]

Just to record, the MaxMemoryPreload shows about 13.7 MB reduction in step3 (reco+DQM) in some 2024 MC workflows such as

• 12834.0_TTbar_14TeV+2024
• 12846.0_ZEE_14+2024
• 13034.0_TTbar_14TeV+2024PU

[mmusich]

Just to record, the MaxMemoryPreload shows about 13.7 MB reduction in step3 (reco+DQM) in some 2024 MC workflows such as

Thanks for the report. Out of curiosity, are you reading this off this table ?

[makortel]

Out of curiosity, are you reading this off this table ?

Yes. We are working towards getting such memory changes reported in the PR test summary message, but it will take some time (partly to build up experience on its behavior to minimize false positives).