Electron hlt filter bits mod #46540

DebabrataBhowmik · 2024-10-29T15:16:24Z

PR description:

This PR is being made to correctly assign the filterbit "HLT30WPTightGSfTrackIso" to the electron trigger objects.
In current versio, we have a filter bit "WPTight" including "WPTight" & "TrackIsoFilter" in the similar line, however this is more generic and have contribution from cross-triggers along with the single electron triger of interest.
Thus it is very important for EGM to have this additional filterbits(being included via this PR) to have the proper filterbit corresponding to the lowest pT, unprescaled, single electron trigger.

PR validation:

This PR just adds one filterbit to the electron trigger objects
Checked with : runTheMatrix.py -l 12846.0
The test passed and the results are as expected

Backportation is not needed for this PR.

…ckIsoFilter

cmsbuild · 2024-10-29T15:16:51Z

cms-bot internal usage

RSalvatico · 2024-10-29T15:17:34Z

type egamma

cmsbuild · 2024-10-29T15:18:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46540/42409

cmsbuild · 2024-10-29T15:18:54Z

A new Pull Request was created by @DebabrataBhowmik for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

RSalvatico · 2024-10-29T15:19:27Z

enable nano

RSalvatico · 2024-10-29T15:19:54Z

please test

cmsbuild · 2024-10-29T21:23:45Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7697f/42445/summary.html
COMMIT: 97141db
CMSSW: CMSSW_14_2_X_2024-10-29-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46540/42445/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log

Expand to see more relval errors ...

2024.101001
2024.000001
2024.001001
2024.100001
2024.101001

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3569372
DQMHistoTests: Total failures: 395
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3568957
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 201 log files, 171 edm output root files, 46 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 381 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 55313
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 55297
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
Checked 102 log files, 58 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	3.012	3.012	0.000 ( +0.0% )	2.97	2.81	+5.7%	2.352	2.339
2500.002	3.124	3.124	0.000 ( +0.0% )	2.66	2.52	+5.9%	2.792	2.362
2500.003	3.065	3.065	0.000 ( +0.0% )	2.77	2.63	+5.3%	2.779	2.372
2500.011	1.591	1.591	0.000 ( +0.0% )	4.67	4.27	+9.2%	2.450	2.445
2500.012	2.113	2.113	0.000 ( +0.0% )	2.79	2.65	+5.5%	2.638	2.256
2500.013	1.936	1.936	0.000 ( +0.0% )	3.96	3.67	+7.7%	2.556	2.247
2500.021	0.022	0.022	0.000 ( +0.0% )	0.93	0.85	+9.7%	2.416	2.421
2500.022	0.022	0.022	0.000 ( +0.0% )	0.90	0.81	+11.1%	2.417	2.416
2500.023	0.022	0.022	0.000 ( +0.0% )	0.88	0.83	+7.1%	2.278	2.279
2500.024	0.022	0.022	0.000 ( +0.0% )	0.67	0.62	+8.5%	2.509	2.502
2500.031	0.035	0.035	0.000 ( +0.0% )	0.81	0.75	+7.5%	2.475	2.490
2500.032	0.036	0.036	0.000 ( +0.0% )	0.83	0.76	+9.4%	2.451	2.449
2500.033	0.037	0.037	0.000 ( +0.0% )	0.75	0.69	+8.0%	2.532	2.520
2500.034	0.036	0.036	0.000 ( +0.0% )	0.76	0.70	+8.3%	2.513	2.502
2500.101	2.766	2.766	0.000 ( +0.0% )	7.53	6.87	+9.6%	2.591	2.586
2500.111	1.419	1.419	0.000 ( +0.0% )	17.13	15.69	+9.2%	2.299	2.299
2500.112	1.838	1.838	0.000 ( +0.0% )	13.77	12.71	+8.3%	2.376	2.376
2500.131	0.747	0.747	0.000 ( +0.0% )	17.95	16.42	+9.3%	1.504	1.509
2500.201	2.595	2.595	0.000 ( +0.0% )	6.35	5.73	+10.9%	2.155	2.152
2500.211	1.757	1.757	0.000 ( +0.0% )	14.96	13.74	+8.9%	2.366	2.358
2500.212	2.152	2.152	0.000 ( +0.0% )	12.36	11.35	+8.9%	2.450	2.444
2500.221	2.016	2.016	0.000 ( +0.0% )	6.66	6.09	+9.3%	2.075	2.075
2500.222	3.392	3.392	0.000 ( +0.0% )	6.18	5.71	+8.3%	2.166	2.155
2500.223	9.357	9.357	0.000 ( +0.0% )	1.79	1.66	+7.7%	2.232	2.233
2500.224	6.040	6.040	0.000 ( +0.0% )	0.59	0.54	+8.7%	2.216	2.173
2500.225	6.072	6.072	0.000 ( +0.0% )	0.56	0.52	+7.7%	2.297	2.252
2500.226	3.086	3.086	0.000 ( +0.0% )	6.29	5.83	+7.8%	2.163	2.148
2500.227	1.437	1.437	0.000 ( +0.0% )	11.74	10.53	+11.5%	1.438	1.426
2500.231	1.429	1.429	0.000 ( +0.0% )	12.29	11.33	+8.5%	2.265	2.255
2500.232	2.412	2.412	0.000 ( +0.0% )	11.53	10.26	+12.4%	2.354	2.353
2500.233	4.904	4.904	0.000 ( +0.0% )	2.74	2.46	+11.2%	2.423	2.412
2500.234	3.670	3.670	0.000 ( +0.0% )	0.75	0.70	+7.7%	2.392	2.146
2500.235	3.689	3.689	0.000 ( +0.0% )	0.72	0.67	+7.2%	2.448	2.197
2500.236	2.202	2.202	0.000 ( +0.0% )	12.23	11.11	+10.1%	2.349	2.352
2500.237	1.016	1.016	0.000 ( +0.0% )	17.05	15.28	+11.6%	1.463	1.442
2500.241	9.404	9.404	0.000 ( +0.0% )	3.65	3.32	+10.1%	1.917	1.917
2500.242	10.331	10.331	0.000 ( +0.0% )	0.89	0.77	+15.9%	1.711	1.701
2500.243	2.712	2.712	0.000 ( +0.0% )	8.25	7.53	+9.5%	1.081	1.076
2500.244	485.976	485.976	0.000 ( +0.0% )	0.56	0.50	+12.8%	1.674	1.678
2500.245	823.202	823.202	0.000 ( +0.0% )	0.74	0.65	+13.4%	1.670	1.654
2500.901	1.777	1.777	0.000 ( +0.0% )	21.32	18.95	+12.5%	1.421	1.413
2500.902	1.626	1.626	0.000 ( +0.0% )	22.03	19.58	+12.5%	1.325	1.318
2500.911	13.995	13.995	0.000 ( +0.0% )	3.27	2.89	+13.0%	1.095	1.088
2500.912	0.240	0.310	-0.070 ( -22.6% )	1.41	1.28	+10.2%	0.977	0.976
2500.913	0.110	0.110	0.000 ( +0.0% )	1.12	1.06	+6.3%	0.980	0.976

hqucms · 2024-10-29T23:54:59Z

+1

cmsbuild · 2024-10-29T23:55:17Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

hqucms · 2024-10-29T23:55:28Z

ignore tests-rejected with ib-failure

mandrenguyen · 2024-10-30T15:16:39Z

+1

DebabrataBhowmik added 2 commits October 28, 2024 12:02

modified TriggerFilterBits to correctly include hltEle30WPTightGsfTra…

f5472cb

…ckIsoFilter

Including correct TriggerBit for hltEle30WPTightGsfTrackIsoFilter

97141db

cmsbuild added this to the CMSSW_14_2_X milestone Oct 29, 2024

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Oct 29, 2024

cmsbuild added the egamma label Oct 29, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 29, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Oct 29, 2024

cmsbuild removed the tests-rejected label Oct 29, 2024

cmsbuild added tests-approved tests-ib-failure labels Oct 29, 2024

cmsbuild added orp-approved and removed orp-pending labels Oct 30, 2024

cmsbuild merged commit 3aa6f59 into cms-sw:master Oct 30, 2024
12 of 13 checks passed

This was referenced Oct 31, 2024

Add PbPbHighPtJets skim for 2024 PbPb #46499

Merged

Update GCC 12.4.1 cms-sw/cmsdist#9303

Open

pileup profile 2025_LHC_Simulation_fill12p5h_levelling9h_nb2340_xSec80mb_il2p23 #46557

Merged

Add GloParT inference facility #46523

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Electron hlt filter bits mod #46540

Electron hlt filter bits mod #46540

DebabrataBhowmik commented Oct 29, 2024

cmsbuild commented Oct 29, 2024 •

edited

Loading

RSalvatico commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

RSalvatico commented Oct 29, 2024

RSalvatico commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

hqucms commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

hqucms commented Oct 29, 2024

mandrenguyen commented Oct 30, 2024

Electron hlt filter bits mod #46540

Electron hlt filter bits mod #46540

Conversation

DebabrataBhowmik commented Oct 29, 2024

PR description:

PR validation:

cmsbuild commented Oct 29, 2024 • edited Loading

RSalvatico commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

RSalvatico commented Oct 29, 2024

RSalvatico commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

RelVals-INPUT

Comparison Summary

NANO Comparison Summary

hqucms commented Oct 29, 2024

cmsbuild commented Oct 29, 2024

hqucms commented Oct 29, 2024

mandrenguyen commented Oct 30, 2024

cmsbuild commented Oct 29, 2024 •

edited

Loading