-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satchel Charges #6924
Satchel Charges #6924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning animation is too fast, make it slower, at least the same speed other things with warnings have, otherwise looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops
Fixed! |
I wish to see this on live, currently from the preview and looking at code I am worried it might be too strong, but we'll see! |
It was previously TM'd and was seen to be quite, as far as I know, balanced, as not many concerns were brought up, however we'll see how the second test goes! |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Fixing conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix conflicts
actually, this is two weeks old, closing due to stale, ask someone to reopen |
About the pull request
Implements the satchel charges and detonators originally coded and abandoned by Totalepicness5.
Explain why it's good for the game
It's C4 that explodes on command, useful for Engineer players to clear a large amount of obstacles at once, they can be countered by taking out the engineer or aciding the charges. They're pretty obvious so they're hard to use for traps, plus the 4 second detonation delay makes it hard to chuck and blow up immediately, not to mention the arming time of 3 seconds from tossing it on top of that. I could maybe see them used to style on crit xenos, but they should end up being used pretty properly for obstacle clearing.
Testing Photographs and Procedure
Screenshots & Videos
Link to the video on Discord!
Changelog
🆑LynxSolstice, Totalepicness5, Thwomper
add: Added satchel charges and the accompanying detonator, added new handling sounds for the satchel charges and detonator (by Thwomper)
imageadd: Added sprites for the satchel charges and detonator (by Thwomper)
/:cl: