Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satchel Charges #6924

Closed

Conversation

LynxSolstice
Copy link
Contributor

@LynxSolstice LynxSolstice commented Aug 11, 2024

About the pull request

Implements the satchel charges and detonators originally coded and abandoned by Totalepicness5.

Explain why it's good for the game

It's C4 that explodes on command, useful for Engineer players to clear a large amount of obstacles at once, they can be countered by taking out the engineer or aciding the charges. They're pretty obvious so they're hard to use for traps, plus the 4 second detonation delay makes it hard to chuck and blow up immediately, not to mention the arming time of 3 seconds from tossing it on top of that. I could maybe see them used to style on crit xenos, but they should end up being used pretty properly for obstacle clearing.

Testing Photographs and Procedure

Screenshots & Videos

Link to the video on Discord!

Changelog

🆑LynxSolstice, Totalepicness5, Thwomper
add: Added satchel charges and the accompanying detonator, added new handling sounds for the satchel charges and detonator (by Thwomper)
imageadd: Added sprites for the satchel charges and detonator (by Thwomper)
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Aug 11, 2024
Copy link
Contributor

@Blundir Blundir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning animation is too fast, make it slower, at least the same speed other things with warnings have, otherwise looks fine.

Copy link
Contributor

@Blundir Blundir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

@Blundir Blundir marked this pull request as draft August 11, 2024 21:56
@LynxSolstice
Copy link
Contributor Author

The warning animation is too fast, make it slower, at least the same speed other things with warnings have, otherwise looks fine.

Fixed!

@LynxSolstice LynxSolstice marked this pull request as ready for review August 11, 2024 22:12
@LynxSolstice LynxSolstice requested a review from Blundir August 11, 2024 22:13
@Blundir Blundir added the Sprites Approved confirmed no stray pixels label Aug 11, 2024
@LynxSolstice LynxSolstice marked this pull request as ready for review October 15, 2024 01:16
@Nanu308 Nanu308 added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Oct 16, 2024
@Nanu308
Copy link
Member

Nanu308 commented Oct 16, 2024

I wish to see this on live, currently from the preview and looking at code I am worried it might be too strong, but we'll see!
adding tm label

@cmss13-ci cmss13-ci bot added the Sound Blast 5 minutes of bass boosted music to our players label Oct 17, 2024
@LynxSolstice
Copy link
Contributor Author

I wish to see this on live, currently from the preview and looking at code I am worried it might be too strong, but we'll see! adding tm label

It was previously TM'd and was seen to be quite, as far as I know, balanced, as not many concerns were brought up, however we'll see how the second test goes!

@LynxSolstice LynxSolstice requested a review from Blundir October 17, 2024 07:58
@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Oct 27, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Oct 27, 2024
@Blundir Blundir added Stale Exempt PR can't go stale Sprites Frozen Merge this and you will make the spritetainers angry. and removed Stale beg a maintainer to review your PR labels Oct 27, 2024
cm13-github added a commit that referenced this pull request Oct 31, 2024
cm13-github added a commit that referenced this pull request Nov 1, 2024
cm13-github added a commit that referenced this pull request Nov 1, 2024
cm13-github added a commit that referenced this pull request Nov 1, 2024
@cm13-issue-bot cm13-issue-bot mentioned this pull request Nov 1, 2024
@thevandie thevandie mentioned this pull request Nov 1, 2024
3 tasks
cm13-github added a commit that referenced this pull request Nov 1, 2024
cm13-github added a commit that referenced this pull request Nov 1, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 10, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@LynxSolstice
Copy link
Contributor Author

Fixing conflicts

@kiVts kiVts removed the Sprites Frozen Merge this and you will make the spritetainers angry. label Dec 28, 2024
Copy link
Contributor

@kiVts kiVts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix conflicts

@kiVts
Copy link
Contributor

kiVts commented Dec 28, 2024

actually, this is two weeks old, closing due to stale, ask someone to reopen

@kiVts kiVts closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code Needs Testing Need to test it on the guinea pigs (production server) Sound Blast 5 minutes of bass boosted music to our players Sprites Remove the soul from the game. Stale Exempt PR can't go stale Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants