Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "in_hands" and "onmob" icon sprites for objects, book import from PVE (thanks Amory), small changes and fixes #6951

Draft
wants to merge 77 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
7a7c03b
R.T.S.1
LC4492 Apr 10, 2024
184b45b
Merge branch 'master' of https://github.com/LC4492/CM-Space-Station-13
LC4492 May 23, 2024
ae3caa1
Merge branch 'cmss13-devs:master' into master
LC4492 Jun 13, 2024
066478e
Merge branch 'cmss13-devs:master' into master
LC4492 Jun 27, 2024
5ddbf4a
Merge branch 'cmss13-devs:master' into master
LC4492 Jul 12, 2024
31e22ad
Merge branch 'cmss13-devs:master' into master
LC4492 Jul 20, 2024
82201a0
Merge branch 'cmss13-devs:master' into master
LC4492 Jul 29, 2024
43797f5
Merge branch 'cmss13-devs:master' into master
LC4492 Aug 6, 2024
6c53f32
Merge branch 'cmss13-devs:master' into master
LC4492 Aug 14, 2024
a66f65f
First Sprite Pack, small changes
LC4492 Aug 14, 2024
04bd561
Fix 1
LC4492 Aug 15, 2024
93f592a
Fix 2
LC4492 Aug 15, 2024
f2559eb
Merge branch 'master' into New-in_hand-sprites
LC4492 Aug 15, 2024
57194f6
Fix 3
LC4492 Aug 15, 2024
aca99c5
fix
Blundir Aug 16, 2024
3a7387d
Merge branch 'cmss13-devs:master' into master
LC4492 Sep 1, 2024
3ec8d4d
Merge branch 'cmss13-devs:master' into master
LC4492 Sep 7, 2024
3d5ff0c
Merge branch 'master' into New-in_hand-sprites
LC4492 Sep 8, 2024
6636854
Merge branch 'New-in_hand-sprites' of https://github.com/LC4492/CM-Sp…
LC4492 Sep 8, 2024
ad2a320
In_hand revolution, Part One
LC4492 Oct 19, 2024
53a75b5
Merge branch 'master' into New-in_hand-sprites
LC4492 Oct 19, 2024
5c6c12f
fix 1=
LC4492 Oct 19, 2024
a9c6df1
fix 2
LC4492 Oct 19, 2024
9611fbe
Fix 3
LC4492 Oct 19, 2024
f56d431
Fix 4
LC4492 Oct 19, 2024
134a7dc
Fix 5
LC4492 Oct 19, 2024
b82dc41
Fix 6
LC4492 Oct 19, 2024
e887ee2
Merge branch 'cmss13-devs:master' into master
LC4492 Oct 21, 2024
6d12062
Snacks, matches (WIP) and fixes
LC4492 Oct 28, 2024
4d2c9f8
Fix 2
LC4492 Oct 28, 2024
bcbd773
Fix 2
LC4492 Oct 28, 2024
bd5e457
Merge branch 'cmss13-devs:master' into master
LC4492 Nov 1, 2024
1966f64
Merge branch 'cmss13-devs:master' into master
LC4492 Nov 25, 2024
b0165df
Merge branch 'cmss13-devs:master' into master
LC4492 Nov 25, 2024
beed03c
Merge branch 'master' into New-in_hand-sprites
LC4492 Nov 25, 2024
4d1937e
Conflict S.
LC4492 Nov 25, 2024
60de4fd
Lost pixel in the mirage
LC4492 Nov 26, 2024
bb7bf54
Update binoculars.dm
Blundir Nov 26, 2024
89d4cb3
Update binoculars.dm
Blundir Nov 26, 2024
2b858d9
Fixes, Updates and Addons
LC4492 Nov 27, 2024
14020f3
Updates, Fixes and Addons 2
LC4492 Nov 27, 2024
31788ab
Pizzas, Dogs, Monkeys and more
LC4492 Nov 28, 2024
cb51b49
Merge branch 'master' of https://github.com/LC4492/CM-Space-Station-13
LC4492 Dec 10, 2024
403da79
Merge branch 'master' into New-in_hand-sprites
LC4492 Dec 10, 2024
3e32e1c
Update to the new era
LC4492 Dec 13, 2024
644c087
Merge branch 'master' of https://github.com/LC4492/CM-Space-Station-13
LC4492 Dec 13, 2024
8bb1ef1
Merge branch 'master' into New-in_hand-sprites
LC4492 Dec 13, 2024
7b3cd26
bino
LC4492 Dec 13, 2024
1a68ba8
Fixes and whatnot
LC4492 Dec 13, 2024
ca2159a
Bino 2
LC4492 Dec 13, 2024
cca543e
Merge branch 'cmss13-devs:master' into master
LC4492 Dec 16, 2024
cb5be7f
Merge branch 'master' into New-in_hand-sprites
LC4492 Dec 16, 2024
0801126
Fixes and whatnot
LC4492 Dec 16, 2024
0759fe7
Fixes and more fixes
LC4492 Dec 16, 2024
33e7543
fix
LC4492 Dec 16, 2024
7495ffa
Fixes and addons
LC4492 Dec 17, 2024
82b69d9
small sorting
Blundir Dec 18, 2024
9239aa3
Merge branch 'master' of https://github.com/cmss13-devs/cmss13 into p…
Blundir Dec 19, 2024
c8a5e13
fixes
Blundir Dec 19, 2024
127c4ef
fixes
Blundir Dec 21, 2024
6079417
Update fancy.dm
Blundir Dec 21, 2024
f60ab26
Update fancy.dm
Blundir Dec 21, 2024
9e615a8
Update fancy.dm
Blundir Dec 21, 2024
0373fd2
Merge branch 'master' into New-in_hand-sprites
Blundir Dec 21, 2024
d29a8f7
upd
Blundir Dec 27, 2024
0d9b4d0
upd on huggers and eggs
Blundir Dec 27, 2024
5b881da
Merge branch 'master' of https://github.com/cmss13-devs/cmss13 into p…
Blundir Dec 27, 2024
cbc7eaf
Fixup maps in TGM format
Blundir Dec 27, 2024
a87242d
fix
Blundir Dec 27, 2024
e39888a
Merge branch 'master' of https://github.com/cmss13-devs/cmss13 into p…
Blundir Dec 27, 2024
2279f2c
removes reference to Corey
Blundir Dec 27, 2024
560ec6f
fix white folder
Blundir Dec 27, 2024
87ee178
Fixup maps in TGM format
Blundir Dec 27, 2024
57ac20a
fix
Blundir Dec 27, 2024
63f481c
All kinds of stuff
LC4492 Dec 27, 2024
edf0b2c
Fixes of fixes
LC4492 Dec 27, 2024
f18e7e0
Fixes and more
LC4492 Dec 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/game/machinery/kitchen/smartfridge.dm
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
var/plants_loaded = 0
for(var/obj/G in P.contents)
if(accept_check(G))
P.remove_from_storage(G,src)
P.remove_from_storage(G, src)
add_local_item(G)
plants_loaded++
if(plants_loaded)
Expand Down
6 changes: 3 additions & 3 deletions code/game/objects/items.dm
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@

if(isstorage(loc))
var/obj/item/storage/S = loc
S.remove_from_storage(src, user.loc)
S.remove_from_storage(src, user.loc, user)

throwing = 0

Expand Down Expand Up @@ -948,8 +948,8 @@

SEND_SIGNAL(src, COMSIG_ITEM_ZOOM, user)
var/zoom_device = zoomdevicename ? "\improper [zoomdevicename] of [src]" : "\improper [src]"
user.visible_message(SPAN_NOTICE("[user] peers through \the [zoom_device]."),
SPAN_NOTICE("You peer through \the [zoom_device]."))
user.visible_message(SPAN_NOTICE("[user] peers through [zoom_device]."),
SPAN_NOTICE("You peer through [zoom_device]."))
zoom = !zoom

/obj/item/proc/get_icon_state(mob/user_mob, slot)
Expand Down
4 changes: 4 additions & 0 deletions code/game/objects/items/ashtray.dm
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
/obj/item/ashtray
icon = 'icons/obj/items/smoking/ashtray.dmi'
item_icons = list(
WEAR_L_HAND = 'icons/mob/humans/onmob/inhands/items/smoking_lefthand.dmi',
WEAR_R_HAND = 'icons/mob/humans/onmob/inhands/items/smoking_righthand.dmi'
)

var/max_butts = 0
var/empty_desc = ""
Expand Down
6 changes: 6 additions & 0 deletions code/game/objects/items/bodybag.dm
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@
name = "body bag"
desc = "A folded bag designed for the storage and transportation of cadavers."
icon = 'icons/obj/bodybag.dmi'
item_icons = list(
WEAR_L_HAND = 'icons/mob/humans/onmob/inhands/equipment/medical_lefthand.dmi',
WEAR_R_HAND = 'icons/mob/humans/onmob/inhands/equipment/medical_righthand.dmi',
)
icon_state = "bodybag_folded"
item_state = "bodybag"
w_class = SIZE_SMALL
var/unfolded_path = /obj/structure/closet/bodybag

Expand Down Expand Up @@ -33,6 +38,7 @@
desc = "A folded, reusable bag designed to prevent additional damage to an occupant."
icon = 'icons/obj/bodybag.dmi'
icon_state = "cryobag_folded"
item_state = "cryobag"
unfolded_path = /obj/structure/closet/bodybag/cryobag
matter = list("plastic" = 7500)
var/used = 0
Expand Down
3 changes: 2 additions & 1 deletion code/game/objects/items/books/book.dm
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@
/obj/item/book
name = "book"
icon = 'icons/obj/items/books.dmi'
icon_state = "book"
item_state = "book_dark"
item_icons = list(
WEAR_L_HAND = 'icons/mob/humans/onmob/inhands/items/books_lefthand.dmi',
WEAR_R_HAND = 'icons/mob/humans/onmob/inhands/items/books_righthand.dmi',
)
icon_state ="book"
throw_speed = SPEED_FAST
throw_range = 5
/// upped to three because books are, y'know, pretty big. (and you could hide them inside eachother recursively forever)
Expand Down
49 changes: 33 additions & 16 deletions code/game/objects/items/books/manuals.dm
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@

/obj/item/book/manual/engineering_construction
name = "Station Repairs and Construction"
icon_state ="bookEngineering"
icon_state = "book_engineering"
item_state = "book_engineering"
author = "Engineering Encyclopedia"
title = "Station Repairs and Construction"

Expand All @@ -31,7 +32,8 @@

/obj/item/book/manual/engineering_hacking
name = "Hacking"
icon_state ="bookHacking"
icon_state = "book_hacking"
item_state = "book_hacking"
author = "Engineering Encyclopedia"
title = "Hacking"

Expand All @@ -51,7 +53,8 @@

/obj/item/book/manual/ripley_build_and_repair
name = "APLU \"Ripley\" Construction and Operation Manual"
icon_state ="book"
icon_state = "book_dark"
item_state = "book_dark"
author = "Randall Varn, Einstein Engines Senior Mechanic"
title = "APLU \"Ripley\" Construction and Operation Manual"

Expand Down Expand Up @@ -128,7 +131,8 @@

/obj/item/book/manual/research_and_development
name = "Research and Development 101"
icon_state = "rdbook"
icon_state = "book_white"
item_state = "book_white"
author = "Dr. L. Ight"
title = "Research and Development 101"

Expand All @@ -149,7 +153,8 @@
/obj/item/book/manual/security_space_law
name = "Standard Operating Procedure"
desc = "A set of USCM guidelines for keeping law and order on their vessels."
icon_state = "bookSpaceLaw"
icon_state = "book_sop"
item_state = "book_sop"
author = "USCM High Command"
title = "Standard Operating Procedure"

Expand All @@ -170,7 +175,8 @@
/obj/item/book/manual/marine_law
name = "Marine Law"
desc = "A set of guidelines for keeping law and order on military vessels."
icon_state = "bookSpaceLaw"
icon_state = "book_law"
item_state = "book_law"
author = "USCM High Command"
title = "Marine Law"

Expand All @@ -191,7 +197,8 @@
/obj/item/book/manual/surgery
name = "Surgical Reference Manual"
desc = "A quick reference manual for surgical procedures."
icon_state = "bookMedical"
icon_state = "book_medical"
item_state = "book_medical"
author = "Weyland-Yutani Medicine Department"
title = "Surgical Reference Manual"

Expand All @@ -212,7 +219,8 @@
/obj/item/book/manual/medical_diagnostics_manual
name = "WY Medical Diagnostics Manual"
desc = "First, do no harm. A detailed medical practitioner's guide."
icon_state = "bookMedical"
icon_state = "book_medical"
item_state = "book_medical"
author = "Weyland-Yutani Medicine Department"
title = "WY Medical Diagnostics Manual"

Expand Down Expand Up @@ -257,7 +265,8 @@

/obj/item/book/manual/engineering_guide
name = "Engineering Textbook"
icon_state ="bookEngineering2"
icon_state = "book_engineering"
item_state = "book_engineering"
author = "Engineering Encyclopedia"
title = "Engineering Textbook"

Expand All @@ -276,7 +285,8 @@

/obj/item/book/manual/chef_recipes
name = "Chef Recipes"
icon_state = "cooked_book"
icon_state = "book_green"
item_state = "book_green"
author = "Victoria Ponsonby"
title = "Chef Recipes"

Expand Down Expand Up @@ -335,7 +345,8 @@

/obj/item/book/manual/barman_recipes
name = "Barman Recipes"
icon_state = "barbook"
icon_state = "book_red"
item_state = "book_red"
author = "Sir John Rose"
title = "Barman Recipes"

Expand Down Expand Up @@ -391,6 +402,7 @@
/obj/item/book/manual/detective
name = "The Film Noir: Proper Procedures for Investigations"
icon_state ="bookDetective"
item_state ="book_red"
author = "Weyland-Yutani"
title = "The Film Noir: Proper Procedures for Investigations"

Expand Down Expand Up @@ -434,7 +446,8 @@

/obj/item/book/manual/nuclear
name = "Fission Mailed: Nuclear Sabotage 101"
icon_state ="bookNuclear"
icon_state = "book_particle"
item_state = "book_particle"
author = "The Colonial Liberation Front"
title = "Fission Mailed: Nuclear Sabotage 101"

Expand Down Expand Up @@ -486,7 +499,8 @@

/obj/item/book/manual/atmospipes
name = "Pipes and You: Getting To Know Your Scary Tools"
icon_state = "pipingbook"
icon_state = "book_piping"
item_state = "book_piping"
author = "Maria Crash, Senior Atmospherics Technician"
title = "Pipes and You: Getting To Know Your Scary Tools"
dat = {"<html>
Expand Down Expand Up @@ -594,7 +608,8 @@

/obj/item/book/manual/evaguide
name = "EVA Gear and You: Not Spending All Day Inside"
icon_state = "evabook"
icon_state = "book_blue"
item_state = "book_blue"
author = "Maria Crash, Senior Atmospherics Technician"
title = "EVA Gear and You: Not Spending All Day Inside"
dat = {"<html>
Expand Down Expand Up @@ -666,7 +681,8 @@

/obj/item/book/manual/hydroponics_beekeeping
name = "The Ins and Outs of Apiculture - A Precise Art"
icon_state ="bookHydroponicsBees"
icon_state = "book_green"
item_state = "book_green"
author = "Beekeeper Dave"
title = "The Ins and Outs of Apiculture - A Precise Art"
dat = {"<html>
Expand Down Expand Up @@ -698,7 +714,8 @@

/obj/item/book/manual/orbital_cannon_manual
name = "USCM Orbital Bombardment System Manual"
icon_state = "bookEngineering"
icon_state = "book_engineering"
item_state = "book_engineering"
author = "USCM R&D"
title = "USCM Orbital Bombardment System Manual"

Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/items/circuitboards/circuitboard.dm
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
WEAR_R_HAND = 'icons/mob/humans/onmob/inhands/equipment/devices_righthand.dmi',
)
icon_state = "id_mod"
item_state = "electronic"
item_state = "circuitboard"
flags_atom = FPRINT|CONDUCT
matter = list("metal" = 50, "glass" = 50)
var/build_path = null
Expand Down
28 changes: 28 additions & 0 deletions code/game/objects/items/devices/binoculars.dm
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
desc = "A military-issued pair of binoculars."
icon = 'icons/obj/items/binoculars.dmi'
icon_state = "binoculars"
item_state = "binoculars"
pickup_sound = 'sound/handling/wirecutter_pickup.ogg'
drop_sound = 'sound/handling/wirecutter_drop.ogg'
flags_atom = FPRINT|CONDUCT|MAP_COLOR_INDEX
Expand All @@ -12,6 +13,9 @@
throwforce = 5
throw_range = 15
throw_speed = SPEED_VERY_FAST
/// If FALSE won't change icon_state to a camo marine bino.
var/uses_camo = TRUE
var/raised = FALSE
item_icons = list(
WEAR_L_HAND = 'icons/mob/humans/onmob/inhands/equipment/devices_lefthand.dmi',
WEAR_R_HAND = 'icons/mob/humans/onmob/inhands/equipment/devices_righthand.dmi',
Expand All @@ -30,11 +34,33 @@

if(SEND_SIGNAL(user, COMSIG_BINOCULAR_ATTACK_SELF, src))
return

if(raised)
set_raised(FALSE, user)
else
set_raised(TRUE, user)

if(MODE_HAS_MODIFIER(/datum/gamemode_modifier/disable_long_range_sentry))
zoom(user, hvh_tile_offset, hvh_zoom_viewsize)
else
zoom(user, tile_offset, viewsize)

/obj/item/device/binoculars/proc/set_raised(to_raise, mob/living/carbon/human/user)
if(!istype(user))
return

if(!to_raise)
raised = FALSE
item_state = icon_state
else if(!COOLDOWN_FINISHED(user, zoom_cooldown))
item_state = icon_state
else
raised = TRUE
item_state = item_state + "_eyes"

user.update_inv_r_hand()
user.update_inv_l_hand()

/obj/item/device/binoculars/dropped(/obj/item/item, mob/user)
. = ..()
on_unset_interaction(user)
Expand All @@ -46,6 +72,7 @@
/obj/item/device/binoculars/on_unset_interaction(mob/user)
flags_atom &= ~RELAY_CLICK
UnregisterSignal(user, COMSIG_HUMAN_MOVEMENT_CANCEL_INTERACTION)
set_raised(FALSE, user)

/obj/item/device/binoculars/proc/interaction_handler()
return COMPONENT_HUMAN_MOVEMENT_KEEP_USING
Expand All @@ -61,6 +88,7 @@
gender = NEUTER
desc = "A pair of binoculars with a rangefinding function. Ctrl + Click turf to acquire it's coordinates. Ctrl + Click rangefinder to stop lasing."
icon_state = "rangefinder"
item_state = "rangefinder"
var/laser_cooldown = 0
var/cooldown_duration = 200 //20 seconds
var/obj/effect/overlay/temp/laser_coordinate/coord
Expand Down
6 changes: 5 additions & 1 deletion code/game/objects/items/devices/defibrillator.dm
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
name = "emergency defibrillator"
desc = "A handheld emergency defibrillator, used to restore fibrillating patients. Can optionally bring people back from the dead."
icon_state = "defib"
item_icons = list(
WEAR_L_HAND = 'icons/mob/humans/onmob/inhands/equipment/medical_lefthand.dmi',
WEAR_R_HAND = 'icons/mob/humans/onmob/inhands/equipment/medical_righthand.dmi',
)
item_state = "defib"
icon = 'icons/obj/items/medical_tools.dmi'
flags_atom = FPRINT|CONDUCT
Expand Down Expand Up @@ -320,7 +324,7 @@
desc = "Result of collaboration between Hyperdyne and Weyland-Yutani, this device can fix major glitches or programming errors of synthetic units, as well as being able to restart a synthetic that has suffered critical failure. It can only be used once before being reset."
icon = 'icons/obj/items/synth/synth_reset_key.dmi'
icon_state = "reset_key"
item_state = "defib"
item_state = "synth_reset_key"
w_class = SIZE_SMALL
charge_cost = 1000
force = 0
Expand Down
3 changes: 2 additions & 1 deletion code/game/objects/items/devices/flash.dm
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "flash"
desc = "Used for blinding and being an asshole. Recharges one flash every 30 seconds. You must wait 1 second between uses for the capacitor to recharge."
icon_state = "flash"
item_state = "flash_device" //Replace me later
item_state = "flash_device1" //Replace me later (Yes sir! *Salute*)
throwforce = 5
w_class = SIZE_SMALL
throw_speed = SPEED_VERY_FAST
Expand All @@ -21,6 +21,7 @@
/obj/item/device/flash/update_icon()
if(broken)
icon_state = "[icon_state]_burnt"
item_state = "flashburnt1"

/obj/item/device/flash/get_examine_text(mob/user)
. = ..()
Expand Down
7 changes: 6 additions & 1 deletion code/game/objects/items/devices/flashlight.dm
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
WEAR_R_HAND = 'icons/mob/humans/onmob/inhands/items/lighting_righthand.dmi',
)
icon_state = "flashlight"
item_state = "flashlight"
item_state = ""
w_class = SIZE_SMALL
flags_atom = FPRINT|CONDUCT
flags_equip_slot = SLOT_WAIST
Expand Down Expand Up @@ -576,8 +576,13 @@
/obj/item/device/flashlight/lantern
name = "lantern"
icon_state = "lantern"
item_state = ""
desc = "A mining lantern."
light_range = 6 // luminosity when on
light_color = "#d69c46"

/obj/item/device/flashlight/lantern/on
on = TRUE

//Signal Flare
/obj/item/device/flashlight/flare/signal
Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/items/devices/lightreplacer.dm
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

icon = 'icons/obj/janitor.dmi'
icon_state = "lightreplacer0"
item_state = "electronic"
item_state = "light_replacer"

flags_atom = FPRINT|CONDUCT
flags_equip_slot = SLOT_WAIST
Expand Down
1 change: 1 addition & 0 deletions code/game/objects/items/disks.dm
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@
name = "nuclear authentication disk"
desc = "Better keep this safe."
icon_state = "nucleardisk"
item_state = "nucleardisk"
w_class = SIZE_TINY
Loading
Loading