Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fax Machine Changes #7678

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Nov 25, 2024

About the pull request

Adds a few features to fax machines.

Explain why it's good for the game

Mostly quality of life benefits.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added a button to certain fax machines to send priority faxes, with additional audio cues.
add: Certain faxes when receiving priority messages will also trigger ARES radio alerts.
fix: Fax machine receiving a fax now plays the correct sound.
add: It is now possible to navigate between sending a message to an entire fax department, or to any individual fax in that department.
/:cl:

@cmss13-ci cmss13-ci bot added UI deletes nanoui/html Feature Feature coder badge Fix Fix one bug, make ten more labels Nov 25, 2024
@L0pz
Copy link
Contributor

L0pz commented Nov 26, 2024

Oh is this to solve how CIC straight up doesn't notice it when they receive a fax?

code/game/machinery/fax_machine.dm Outdated Show resolved Hide resolved
code/game/machinery/fax_machine.dm Outdated Show resolved Hide resolved
code/game/machinery/fax_machine.dm Outdated Show resolved Hide resolved
code/game/machinery/fax_machine.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft November 26, 2024 15:26
@realforest2001 realforest2001 added this to the Fax Responders milestone Nov 26, 2024
Co-authored-by: harryob <me@harryob.live>
@realforest2001
Copy link
Member Author

Will be stealing an idea from #7706

@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Dec 17, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Dec 17, 2024
@realforest2001 realforest2001 removed the Stale beg a maintainer to review your PR label Dec 18, 2024
@cmss13-ci cmss13-ci bot added the Mapping did you remember to save in tgm format? label Dec 18, 2024
@realforest2001 realforest2001 marked this pull request as ready for review December 18, 2024 20:28
@realforest2001 realforest2001 changed the title (WIP) Fax Machine Changes Fax Machine Changes Dec 18, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? UI deletes nanoui/html
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

4 participants