Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugging respawn delay and join as xeno refactoring #7679

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Nov 26, 2024

About the pull request

This PR sets a time of death on a successful hug. However, that time of death will not affect their position in larva queue. It also updates the join as facehugger verb to mention that eggs are also a way to join as a facehugger.

This has been revised to only prevent immediate respawning as a lesser drone on successful hug (huggers can still try to become a hugger again immediately). I also bumped the lesser drone respawn time from 30s to 1 minute, and fixed a situation where the join as xeno button wasn't checking the bypass_time_of_death_checks variable set for lessers & huggers.

In addition, there were various inconsistencies between joining as a xeno between larva queue, ctrl click, and join as xeno verb that have been rectified.

To recap:

  • Dying as a hugger or lesser drone will not alter your larva queue position, and now the join as xeno button being used to take over an afk xeno will not be prevented for recent death (larva queue already had this exception).
  • Dying as a lesser will require you to wait 1 minute to respawn as a lesser again, or 3 minutes to respawn as a hugger.
  • Dying as a hugger will require you to wait 1 minute to respawn as a lesser, or 3 minutes to respawn as a hugger again.
  • Successfully hugging as a hugger will require you to wait 1 minute to respawn as a lesser, or 0 minutes to respawn as a hugger again.

Explain why it's good for the game

A lone player hugging someone, then immediately spawning as a lesser to go rush to that cap borders on breaking the metagaming rule even though the entire hive should have the knowledge of the hug (they were part of the hive but became a ghost). At the moment another ghost could just then immediately spawn and go cap that new hug, but that will be later mitigated with https://hackmd.io/@Drathek/rJ9zXhzSC

Testing Photographs and Procedure

Screenshots & Videos

Hugger testing:
https://youtu.be/fjcy8L32w1U (prior to 1 minute respawn change for lesser)

Join as xeno refactoring:
https://youtu.be/HnsVlBq8DDc

Changelog

🆑 Drathek
balance: Player huggers now have to wait 1 minute to respawn as a lesser on successful hug (same as death). They can still immediately respawn as a hugger on successful hug.
balance: Lesser drones respawn time has been increased from 30s to 1 minute.
fix: Join as xeno button/verb (much like larva queue) no longer considers a recent hugger/lesser death as a reason to deny it.
fix: Fixed join as xeno button/verb allowing 0 health afk xenos to be controlled.
fix: Fixed the xeno_bypass_timer gamemode flag skipping inactivity checks.
refactor: Refactored some of the join as xeno code inconsistencies and changed prompts to tgui_alert
spellcheck: Mentioned eggs when using join as facehugger verb.
/:cl:

@cmss13-ci cmss13-ci bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Nov 26, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Nov 26, 2024
@Drulikar Drulikar marked this pull request as draft November 26, 2024 05:33
@cmss13-ci cmss13-ci bot added the Fix Fix one bug, make ten more label Nov 26, 2024
@Drulikar Drulikar marked this pull request as ready for review November 26, 2024 06:55
@cmss13-ci cmss13-ci bot added the Refactor Make the code harder to read label Nov 26, 2024
@Drulikar Drulikar changed the title Hugging respawn delay Hugging respawn delay and join as xeno refactoring Nov 26, 2024
@harryob harryob added this pull request to the merge queue Nov 27, 2024
Merged via the queue into cmss13-devs:master with commit 1cbab9a Nov 27, 2024
30 checks passed
cmss13-ci bot added a commit that referenced this pull request Nov 27, 2024
@Drulikar Drulikar deleted the Hugger_Wait branch November 27, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Refactor Make the code harder to read
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants