Hugging respawn delay and join as xeno refactoring #7679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR sets a time of death on a successful hug. However, that time of death will not affect their position in larva queue. It also updates the join as facehugger verb to mention that eggs are also a way to join as a facehugger.
This has been revised to only prevent immediate respawning as a lesser drone on successful hug (huggers can still try to become a hugger again immediately). I also bumped the lesser drone respawn time from 30s to 1 minute, and fixed a situation where the join as xeno button wasn't checking the bypass_time_of_death_checks variable set for lessers & huggers.
In addition, there were various inconsistencies between joining as a xeno between larva queue, ctrl click, and join as xeno verb that have been rectified.
To recap:
Explain why it's good for the game
A lone player hugging someone, then immediately spawning as a lesser to go rush to that cap borders on breaking the metagaming rule even though the entire hive should have the knowledge of the hug (they were part of the hive but became a ghost). At the moment another ghost could just then immediately spawn and go cap that new hug, but that will be later mitigated with https://hackmd.io/@Drathek/rJ9zXhzSC
Testing Photographs and Procedure
Screenshots & Videos
Hugger testing:
https://youtu.be/fjcy8L32w1U (prior to 1 minute respawn change for lesser)
Join as xeno refactoring:
https://youtu.be/HnsVlBq8DDc
Changelog
🆑 Drathek
balance: Player huggers now have to wait 1 minute to respawn as a lesser on successful hug (same as death). They can still immediately respawn as a hugger on successful hug.
balance: Lesser drones respawn time has been increased from 30s to 1 minute.
fix: Join as xeno button/verb (much like larva queue) no longer considers a recent hugger/lesser death as a reason to deny it.
fix: Fixed join as xeno button/verb allowing 0 health afk xenos to be controlled.
fix: Fixed the xeno_bypass_timer gamemode flag skipping inactivity checks.
refactor: Refactored some of the join as xeno code inconsistencies and changed prompts to tgui_alert
spellcheck: Mentioned eggs when using join as facehugger verb.
/:cl: