Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fax responder renovation #7758

Merged
merged 15 commits into from
Dec 31, 2024
Merged

Fax responder renovation #7758

merged 15 commits into from
Dec 31, 2024
+6,995 −2,479

Conversation

Syndro101
Copy link
Contributor

@Syndro101 Syndro101 commented Dec 7, 2024 •
edited
Loading

About the pull request

Completely renovates the offices used by fax responders to a much higher quality.

Explain why it's good for the game

Adds more depth to the job other than being stuck in a cubicle and looks nice.

Testing Photographs and Procedure

Screenshots & Videos

StrongDMM-2024-12-07 11 02 41

Changelog

🆑
add: Added a new area for the sector relay.
mapadd: Added new offices for Fax Responders.
maptweak: Renamed the old map.
fix: Fax responders no longer count to round end.
/:cl:

@Syndro101 Syndro101 requested a review from Nanu308 as a code owner December 7, 2024 16:05
@cmss13-ci cmss13-ci bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? UI deletes nanoui/html Feature Feature coder badge labels Dec 7, 2024
@realforest2001 realforest2001 added this to the Fax Responders milestone Dec 7, 2024
@realforest2001 realforest2001 mentioned this pull request Dec 7, 2024
Closed
@Syndro101 Syndro101 changed the title Fax responder renovation Fax responder renovation (Dont Merge) Dec 7, 2024
@realforest2001 realforest2001 force-pushed the Fax_Responder_Renovation branch from e569069 to 521e971 Compare December 7, 2024 16:15
@realforest2001 realforest2001 changed the title Fax responder renovation (Dont Merge) Fax responder renovation Dec 7, 2024
@realforest2001 realforest2001 removed Feature Feature coder badge Sprites Remove the soul from the game. UI deletes nanoui/html labels Dec 7, 2024
@cmss13-ci cmss13-ci bot added the Feature Feature coder badge label Dec 7, 2024
@cmss13-ci cmss13-ci bot added the Fix Fix one bug, make ten more label Dec 7, 2024
@thevandie
Copy link
Contributor

you should give the WY responder a Liaison's Wardrobe so he can drip himself out

Nanu308
Nanu308 requested changes Dec 15, 2024
View reviewed changes
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good changes and environmentally fitting areas made for each faction here. Well done overall 👍

See comment on HC/Provost, other than that mapping lgtm

code/game/area/admin_level.dm Outdated Show resolved Hide resolved
code/game/turfs/open.dm Outdated Show resolved Hide resolved
code/game/turfs/shiva.dm Outdated Show resolved Hide resolved
maps/templates/lazy_templates/fax_responder_base.dmm Outdated Show resolved Hide resolved
@Nanu308 Nanu308 marked this pull request as draft December 15, 2024 06:19
@Syndro101 Syndro101 marked this pull request as ready for review December 15, 2024 08:32
@Syndro101
Copy link
Contributor Author

Everything should be ready to go.

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Dec 15, 2024
Nanu308
Nanu308 approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

harryob
harryob requested changes Dec 16, 2024
View reviewed changes
code/game/bioscans.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft December 16, 2024 08:47
@Syndro101 Syndro101 marked this pull request as ready for review December 17, 2024 19:11
@Syndro101 Syndro101 requested a review from harryob December 17, 2024 19:12
@realforest2001 realforest2001 mentioned this pull request Dec 18, 2024
Draft
@realforest2001 realforest2001 added this pull request to the merge queue Dec 31, 2024
Merged via the queue into cmss13-devs:master with commit 484923b Dec 31, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Dec 31, 2024
@cmss13-ci
Automatic changelog for PR #7758 [ci skip]
bddfea0
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Dec 31, 2024
@Syndro101 @realforest2001 @Git-Nivrak
Fax responder renovation (cmss13-devs#7758)
ae0fcb9 
# About the pull request

Completely renovates the offices used by fax responders to a much higher
quality.

# Explain why it's good for the game

Adds more depth to the job other than being stuck in a cubicle and looks
nice.

# Testing Photographs and Procedure

<details>
<summary>Screenshots & Videos</summary>

![StrongDMM-2024-12-07 11 02
41](https://github.com/user-attachments/assets/6c989c6b-4483-4cbe-a233-cdb28551b213)

</details>


# Changelog

:cl:
add: Added a new area for the sector relay.
mapadd: Added new offices for Fax Responders.
maptweak: Renamed the old map.
fix: Fax responders no longer count to round end.
/:cl:

---------

Co-authored-by: forest2001 <ingram.josh@gmail.com>
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Dec 31, 2024
@cmss13-ci @Git-Nivrak
Automatic changelog for PR cmss13-devs#7758 [ci skip]
5bb4610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nanu308 Nanu308 Nanu308 approved these changes

@harryob harryob Awaiting requested review from harryob

Assignees
No one assigned
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
Review Backlog
Status: Merged
Milestone
Fax Responders
Development

Successfully merging this pull request may close these issues.
5 participants
@Syndro101 @thevandie @harryob @Nanu308 @realforest2001