This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Add cardinality estimate to AbstractPlan object #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linmagit
reviewed
Sep 7, 2018
src/optimizer/stats_calculator.cpp
Outdated
| predicate_stats, op->predicates); | ||
| // Use predicates to estimate cardinality | ||
| if (table_stats->GetColumnCount() == 0) { | ||
| root_group->SetNumRows(0); |
There was a problem hiding this comment.
When will this happen? When the table is empty? Or no stats exists? Or the cardinality estimation is 0?
There was a problem hiding this comment.
This would happen if ColumnStatsCatalog::GetTableStats returned no column stats. I believe this would happen if the catalog did not have stats for the table. This is assuming its not possible to have a table without columns.
added 2 commits
September 8, 2018 14:46
linmagit
approved these changes
Sep 10, 2018
mtunique
pushed a commit
to mtunique/peloton
that referenced
this pull request
Apr 16, 2019
* Clarified variable name * Added cardinality and test * Add optimizer testing class * Remove debugging code * Revert default estimate to fix broken test * Formatting * Removed unecessary override in Cardinality test * More comments and clean up tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the optimizer's cardinality estimate to the AbstractPlan object for use during plan execution. Includes test cases to verify it works. This is part of #1467 to add more optimizer estimates to plans.
Additionally, this PR adds an optimizer_test_util class with useful helper functions for creating test tables and generating plans. Future and possibly existing test cases should inherit from this class.