This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Fix CSV scanner for handling filter predicate on a VARCHAR column correctly #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSV scan does not care about delimiter in a CSV file, but query processor should care the end of each column value, i.e., ‘\0’. Because query parser parses each selection predicate by adding ‘\0’ at the end of the predicate value, query processor cannot handle the query correctly if we ignore the existence of delimiter in a raw tuple in CSV file. This simple solution fix the case by replacing delimiter to ‘\0’, and thus StringCompare in type/type_util.h works correctly.
-----------------------------------------------------------------
/data/system/dev/peloton/src/util/file.cpp: In member function ‘void peloton::util::File::Open(const string&, peloton::util::File::AccessMode)’:
/data/system/dev/peloton/src/util/file.cpp:41:36: error: ‘flags’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
int fd = open(name.c_str(), flags);
^
At global scope:
cc1plus: error: unrecognized command line option ‘-Wno-implicit-fallthrough’ [-Werror]
|
Thanks for sending this. We're not actively developing Peloton anymore. We'll eventually port this over to the new system. |
|
@apavlo Hello, professor. It is my pleasure if this PR can improve the new system in any way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV scan does not care about delimiter in a CSV file, but query
processor should care the end of each column value, i.e., ‘\0’.
Because query parser parses each selection predicate by adding ‘\0’ at
the end of the predicate value, query processor cannot handle the query
correctly if we ignore the existence of delimiter in a raw tuple in CSV
file.
This simple solution fix the case by replacing delimiter to ‘\0’, and
thus StringCompare in type/type_util.h works correctly.