adds 3 new widget types: loading, layout and layer. #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds 3 new entry points within the Controller when widgets can be created. use the widget's key internally when no id is available
|
Flexibility is always good. Documentation will be key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds 3 new entry points within the Controller to manage when widgets can be created.
Also includes a change to uses the widget's key internally when no id is available. Some Esri widgets cannot have an id passed in the config.
loadingwidgets are created as early as possible - just after the config file is loaded. Example might be a progress bar.layoutwidgets are created after the layout is built but prior to panes being created and the map is loaded. Example: adjust the layout before any contents are added. Not sure of the usefulness of this type. Open for discussion.layerwidgets (andmapwidgets) created after the map and layers have been loaded but prior to panes being created and before other widgets are loaded. Example: setting the definition expression for a feature layer. Similar in concept to a layerloadevent but easier to compartmentalize and manage the code as a widget.