Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Update links to point localized pages #870

Merged
merged 2 commits into from
May 9, 2022

Conversation

jihoon-seo
Copy link
Collaborator

@jihoon-seo jihoon-seo commented May 8, 2022

  • Update links to the localized version if exists.
  • Replace absolute links (https://glossary.cncf.io/some_URI) with relative ones.
    (Remove hardcoded site domain name)
  • Replace a link to 'http' with one to 'https'.
  • Fix some broken links.

@netlify
Copy link

netlify bot commented May 8, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit da34813
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6278550699f7e10008791ba8
😎 Deploy Preview https://deploy-preview-870--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo jihoon-seo added the lang/zh for Chinese label May 8, 2022
@jihoon-seo
Copy link
Collaborator Author

jihoon-seo commented May 8, 2022

Dear Chinese contributors,
if you use full-width (em-size) parenthesis characters (, ) when making Markdown hyperlinks,
that hyperlinks would be broken:

[Markdown code]
image

[Netlify preview]
image

So, please use half-width parenthesis characters ((, )) to make Markdown hyperlinks!

The 2nd commit (da34813) of this PR is to fix this issue.

@Rocksnake
Copy link
Collaborator

Rocksnake commented May 9, 2022

Dear Chinese contributors, if you use full-width (em-size) parenthesis characters (, ) when making Markdown hyperlinks, that hyperlinks would be broken:

[Markdown code] image

[Netlify preview] image

So, please use half-width parenthesis characters ((, )) to make Markdown hyperlinks!

The 2nd commit (da34813) of this PR is to fix this issue.

Great thanks, we will pay attention to these specifications later.

Copy link
Collaborator

@Rocksnake Rocksnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Jacob953 Jacob953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! LGTM!

@Jacob953 Jacob953 merged commit 151eccc into cncf:dev-zh May 9, 2022
@jihoon-seo jihoon-seo deleted the 220509_zh_Update_links branch May 9, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/zh for Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants