-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lfx term 3: add CRI-O projects #1036
Conversation
#### Add additional log drivers to conmon-rs | ||
|
||
- Description: conmon-rs is a container monitor written in Rust, used by CRI-O to monitor a container's lifecycle. Part of its responsibilities is log forwarding--taking the output of the container and writing that output to various places. Currently, conmon-rs supports one format: the one required by the Kubernetes CRI. The goal of this proposal is to add new log formats from the list of standardized ones, like JSON, Splunk, Journald. | ||
- Expected outcome: A JSON log driver and Journald log driver are added to conmon-rs. A stretch goal of adding a Splunk log driver is also within scope. | ||
- Recommended Skills: Rust, familiarity with containers | ||
- Mentor(s): | ||
- Peter Hunt, haircommander, pehunt@redhat.com | ||
- Sascha Grunert, saschagrunert, sgrunert@redhat.com | ||
- Upstream Issue (URL): https://github.com/containers/conmon-rs/issues/1126 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned that this may not fit the criteria for a CNCF LFX Mentoring project as I don't see Containers as a CNCF project (that said, if it's a new one that I've missed, please accept my mea culpa).
I see that this would help CRI-O; is there a way you could work this into your project more directly, @haircommander?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so conmon-rs is a project shared by cri-o and it's sibling (non cncf project) podman. adding support here will directly benefit cri-o as there have been asks of splunk logging in the past, as well as current support for journald logs that needs porting. FWIW: the GSoC project we're currently working on is also on conmon-rs by extension of cri-o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the context. I think we can bring this in. 🙂
#### Automate CRI-O release process | ||
|
||
- Description: CRI-O packages to openSUSE's [OBS](build.opensuse.org) to provide packages for a variety of Linux distributions. Much of this process is manual today, and could be automated. | ||
- Expected outcome: A github action that reacts to a tag being pushed to CRI-O that packages CRI-O to all the required distributions. | ||
- Recommended Skills: Golang | ||
- Mentor(s): | ||
- Peter Hunt, haircommander, pehunt@redhat.com | ||
- Upstream Issue (URL): https://github.com/cri-o/cri-o/issues/4003 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should add that. We could wait for the official Kubernetes OBS support and integrate into it.
See KEP: kubernetes/enhancements#1731
Or board: https://github.com/orgs/kubernetes/projects/137/views/1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the rough timeline on these changes? Is it more than a year out do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we'll have something concrete by the end of the year, the alpha OBS implementation will be done with v1.28.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to make an update to this before I merge it in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also leave it, just wanted to highlight overlapping efforts here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, let's drop it for now and maybe consider term 4 once upstream has fully committed to a direction
@saschagrunert |
Signed-off-by: Peter Hunt <pehunt@redhat.com>
bd35098
to
6516126
Compare
we have decided to push back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @haircommander & @saschagrunert, I appreciate you participating!
No description provided.