Initialize the Japanese Localization Guidelines #259

Okabe-Junya · 2024-06-15T16:00:21Z

ref. #153
Deploy preview: link

Feature Description

Initialize the Japanese Localization Guidelines
- for new contributors and many members

The Japanese Localization Guidelines include the following contents:

Style Guide
How to write specific terms in Japanese
List of projects with ongoing Japanese localization, and the leads and l10n reviewers for each project
Communication methods

Background

Our project started with the cncf/glossary, and now we are working on l10n for other TAGs and WGs (for example, tag-runtime#145, tag-app-delivery#521). Through this, we have realized the importance of more general l10n documentation (and we think this issue is the best place to discuss it! Thank you @/nate-double-u ).

Okabe-Junya · 2024-06-15T16:05:54Z

To move forward this PR, I would like to do the following:

Accept reviews from Japanese localization reviewers for about a week (until 2024-06-23 00:00 UTC)
Review and merge by reviewers / maintainers from cncf/techdocs

docs/localization/ja/README.md

nate-double-u · 2024-06-17T17:29:20Z

Thanks so much for this!

Could you update this PR to add a section to the CNCF Localization Guides page (/docs/localization/README.md) to introduce these language-specific guides?

I think it would be good to have an English version of this as well (even if it's very rough or just an outline). I'd like to use this work as a template or starting point for other languages. I can't read Japanese, but I assume that there is a process being laid out here that could be generalized.

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

Okabe-Junya · 2024-06-17T18:47:46Z

Thank you, @nate-double-u!!

Could you update this PR to add a section to the CNCF Localization Guides page (/docs/localization/README.md) to introduce these language-specific guides?

Ok!! I added ## Localization READMEs section, bb84976.

I think it would be good to have an English version of this as well (even if it's very rough or just an outline)

SGTM!! Now, I create localization README template and will open another PR - IMO, it would be better to create another PR. Thank you :)

nate-double-u · 2024-06-17T18:49:46Z

Thank you, @nate-double-u!!

😊

Could you update this PR to add a section to the CNCF Localization Guides page (/docs/localization/README.md) to introduce these language-specific guides?

Ok!! I added ## Localization READMEs section, bb84976.

Perfect, thanks!

I think it would be good to have an English version of this as well (even if it's very rough or just an outline)

SGTM!! Now, I created localization template and will open another PR - IMO, it would be better to create another PR. Thank you :)

That's a good idea, it is a separate (related) thing, and should be in a separate PR—good call.

nate-double-u · 2024-06-17T18:53:15Z

I think that running npm run fix:format locally will fix the format/link checks.

This doesn't have to happen yet—we've still got time before the Japanese localization reviews are in.

Okabe-Junya · 2024-06-17T19:01:07Z

Thank you :)

I think that running npm run fix:format locally will fix the format/link checks.

TBH, prettier does not work well for Japanese, since prettier breaks line after a certain number of characters (Please note that Japanese doesn't break lines except "。" (like .))

So, I want to disable linter (at least the Japanese README)

nate-double-u · 2024-06-17T19:24:18Z

That's fair—I think you can disable things per folder. @chalin to confirm as the lead on the reformatting project (note, they are away this week)

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

Okabe-Junya · 2024-06-18T07:35:19Z

I’ve disabled prettier for Japanese README, e2e6bf1

(I'll revert it if there are any issues.)

chalin · 2024-06-25T17:24:38Z

Hi all. Thank you for this initiative @Okabe-Junya. I was away. I'm back but still catching up. I'll get to this as soon as I can. In the meantime, let me cc a few extra people for feedback:

@a-mccarthy
@open-telemetry/docs-ja-approvers: @katzchang, @ymotongpoo

Okabe-Junya · 2024-06-25T17:54:11Z

Thank you, I appreciate your support, chalin!

I have already informed katzchang, ymotongpoo about this PR. (I announced this PR on the #glossary-localization-japanese channel in CNCF Slack, and they are there!)

Once we receive feedback from a-mccarthy, we can move forward! Thank you :)

chalin · 2024-06-25T21:48:51Z

Thank you for the clarifications @Okabe-Junya.

In addition to @a-mccarthy's feedback, I would appreciate if the following could formally approve this PR:

All the currently listed reviewers on this PR
@katzchang
@ymotongpoo

naonishijima

LGTM

hhiroshell

Thanks for your hard work!

ymotongpoo · 2024-06-26T02:27:47Z

LGTM

kenta-iijima · 2024-06-26T02:48:14Z

LGTM

katzchang · 2024-06-26T04:03:47Z

LGTM👍

chalin

Thank you @Okabe-Junya. See inline comments.

docs/localization/README.md

.prettierignore

docs/localization/ja/README.md

Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

Okabe-Junya · 2024-06-28T09:34:29Z

Thank you for the wonderful review, @chalin. Your feedback is very thorough and helpful!

Based on your comments, I have made some revisions. I have also replied to some of your comments (to discuss)

Thanks!

chalin

LGTM, thank you for the updates.

Okabe-Junya · 2024-07-01T15:11:18Z

Thank you for your support, chalin!

nate-double-u

Thanks @Okabe-Junya, and everyone on the Japanese localization team. Great work here!

* feat: initialize Japanese l10n guide Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> * update: add review section Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> * fix: anchor link Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> * Update: l10n reviewer Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> * fix: linter errors Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> * feat: add ## Localization READMEs Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> * fix: link checker error Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> * update: .prettierignore Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> * Update docs/localization/README.md Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> * Update .prettierignore Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> * fix: L6 Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> --------- Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp> Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>

Okabe-Junya force-pushed the feat/initialize-japanese-l10n-guide branch from 2d79ef8 to 99f6627 Compare June 15, 2024 16:00

Okabe-Junya commented Jun 15, 2024

View reviewed changes

docs/localization/ja/README.md Outdated Show resolved Hide resolved

Okabe-Junya force-pushed the feat/initialize-japanese-l10n-guide branch from b145bbd to 115d298 Compare June 15, 2024 16:31

Okabe-Junya commented Jun 15, 2024

View reviewed changes

docs/localization/ja/README.md Outdated Show resolved Hide resolved

kaitoii11 approved these changes Jun 17, 2024

View reviewed changes

Okabe-Junya and others added 6 commits June 18, 2024 03:28

feat: initialize Japanese l10n guide

e746b80

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

update: add review section

4af479e

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

fix: anchor link

3c30feb

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

Update: l10n reviewer

eded7d6

Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com> Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

fix: linter errors

cb511ea

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

feat: add ## Localization READMEs

bb84976

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

Okabe-Junya force-pushed the feat/initialize-japanese-l10n-guide branch from bdb1d37 to bb84976 Compare June 17, 2024 18:28

Okabe-Junya mentioned this pull request Jun 17, 2024

Initialize Localization READMEs template #260

Open

Okabe-Junya added 2 commits June 18, 2024 16:30

fix: link checker error

40e8191

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

update: .prettierignore

e2e6bf1

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

chalin mentioned this pull request Jun 25, 2024

[ja] CNCF localization guidelines - feedback requested open-telemetry/opentelemetry.io#4746

Closed

naonishijima approved these changes Jun 26, 2024

View reviewed changes

hhiroshell approved these changes Jun 26, 2024

View reviewed changes

ymotongpoo approved these changes Jun 26, 2024

View reviewed changes

kenta-iijima approved these changes Jun 26, 2024

View reviewed changes

katzchang approved these changes Jun 26, 2024

View reviewed changes

chalin reviewed Jun 26, 2024

View reviewed changes

Okabe-Junya and others added 3 commits June 28, 2024 17:36

Update docs/localization/README.md

e16bf43

Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

Update .prettierignore

458087c

Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>

fix: L6

f4b493d

Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>

Okabe-Junya requested a review from chalin June 28, 2024 09:30

chalin approved these changes Jul 1, 2024

View reviewed changes

nate-double-u approved these changes Jul 2, 2024

View reviewed changes

nate-double-u merged commit 75cc9b0 into cncf:main Jul 2, 2024
5 checks passed

Okabe-Junya deleted the feat/initialize-japanese-l10n-guide branch July 2, 2024 01:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initialize the Japanese Localization Guidelines #259

Initialize the Japanese Localization Guidelines #259

Okabe-Junya commented Jun 15, 2024 •

edited

Loading

Okabe-Junya commented Jun 15, 2024 •

edited

Loading

nate-double-u commented Jun 17, 2024 •

edited

Loading

Okabe-Junya commented Jun 17, 2024 •

edited

Loading

nate-double-u commented Jun 17, 2024

nate-double-u commented Jun 17, 2024 •

edited

Loading

Okabe-Junya commented Jun 17, 2024 •

edited

Loading

nate-double-u commented Jun 17, 2024 •

edited

Loading

Okabe-Junya commented Jun 18, 2024

chalin commented Jun 25, 2024

Okabe-Junya commented Jun 25, 2024

chalin commented Jun 25, 2024

naonishijima left a comment

hhiroshell left a comment

ymotongpoo commented Jun 26, 2024

kenta-iijima commented Jun 26, 2024

katzchang commented Jun 26, 2024

chalin left a comment

Okabe-Junya commented Jun 28, 2024

chalin left a comment

Okabe-Junya commented Jul 1, 2024

nate-double-u left a comment

Initialize the Japanese Localization Guidelines #259

Initialize the Japanese Localization Guidelines #259

Conversation

Okabe-Junya commented Jun 15, 2024 • edited Loading

Feature Description

Background

Okabe-Junya commented Jun 15, 2024 • edited Loading

nate-double-u commented Jun 17, 2024 • edited Loading

Okabe-Junya commented Jun 17, 2024 • edited Loading

nate-double-u commented Jun 17, 2024

nate-double-u commented Jun 17, 2024 • edited Loading

Okabe-Junya commented Jun 17, 2024 • edited Loading

nate-double-u commented Jun 17, 2024 • edited Loading

Okabe-Junya commented Jun 18, 2024

chalin commented Jun 25, 2024

Okabe-Junya commented Jun 25, 2024

chalin commented Jun 25, 2024

naonishijima left a comment

Choose a reason for hiding this comment

hhiroshell left a comment

Choose a reason for hiding this comment

ymotongpoo commented Jun 26, 2024

kenta-iijima commented Jun 26, 2024

katzchang commented Jun 26, 2024

chalin left a comment

Choose a reason for hiding this comment

Okabe-Junya commented Jun 28, 2024

chalin left a comment

Choose a reason for hiding this comment

Okabe-Junya commented Jul 1, 2024

nate-double-u left a comment

Choose a reason for hiding this comment

Okabe-Junya commented Jun 15, 2024 •

edited

Loading

Okabe-Junya commented Jun 15, 2024 •

edited

Loading

nate-double-u commented Jun 17, 2024 •

edited

Loading

Okabe-Junya commented Jun 17, 2024 •

edited

Loading

nate-double-u commented Jun 17, 2024 •

edited

Loading

Okabe-Junya commented Jun 17, 2024 •

edited

Loading

nate-double-u commented Jun 17, 2024 •

edited

Loading