Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment #263

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

tintinnabulate
Copy link

No description provided.

@cnlohr
Copy link
Owner

cnlohr commented Jan 29, 2024

how is the reference redundant?

@tintinnabulate
Copy link
Author

tintinnabulate commented Feb 1, 2024

@cnlohr

how is the reference redundant?

The reference in the comment is to PORTC pin 6, but WS2812BSimpleSend(..) takes port and pin as parameters. Hence the reference is redundant.

@cnlohr
Copy link
Owner

cnlohr commented Feb 1, 2024

OH MY GOSH. I am so blind. Thank you for this PR.

@cnlohr cnlohr merged commit f3e37e8 into cnlohr:master Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants