Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @swc/types@0.1.16 as a bug version, fallback to 0.1.12 #259

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat: add @swc/types@0.1.16 as a bug version, fallback to 0.1.12 #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,6 +992,12 @@
"reason": "https://github.com/swc-project/swc/issues/7203"
}
},
"@swc/types": {
"0.1.16": {
"version": "0.1.12",
"reason": "https://github.com/swc-project/swc/issues/9753"
}
},
Comment on lines +995 to +1000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

The bug-version entry is correctly configured and the issue reference should be updated

The downgrade from v0.1.16 to v0.1.12 is correct as issue #9752 confirms that @swc/types versions >= 0.1.13 lack the index.js file, causing module resolution failures. However, the current reference points to issue #9753 which is about a different problem. The entry should reference issue #9752 instead.

  • Update the issue reference in the reason field from #9753 to #9752
🔗 Analysis chain

LGTM! The bug-version entry is correctly configured.

The entry properly specifies the problematic version (0.1.16) and the fallback version (0.1.12), following the established pattern in the file.

Let's verify the referenced issue:

The referenced issue is not related to the missing index.js file

The issue #9753 in the swc-project/swc repository is about a different problem: "Cannot use import statement outside a module" in version 0.1.16. This doesn't match the stated rationale for downgrading to v0.1.12 (missing index.js file).

Let's verify if there are any other relevant issues:

Let's check the content of issue #9752 as it seems more relevant:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the issue exists and is related to the missing index.js

# Check if the issue exists and get its details
gh issue view 9753 --repo swc-project/swc

Length of output: 1381

Script:

#!/bin/bash
# Search for issues mentioning index.js and @swc/types
gh search issues "index.js @swc/types" --repo swc-project/swc --limit 5

# Also check if the package.json has any comments or related configuration
rg -A 2 -B 2 "@swc/types" package.json

Length of output: 344

Script:

#!/bin/bash
# Get details of the more relevant issue
gh issue view 9752 --repo swc-project/swc

Length of output: 1831

"undici": {
"5.22.0": {
"version": "5.21.2",
Expand Down
Loading