Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to disable sync unpkg files #679

Merged
merged 1 commit into from
May 14, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented May 14, 2024

Summary by CodeRabbit

  • New Features

    • Added a new configuration option enableSyncUnpkgFiles for enhanced synchronization control.
  • Improvements

    • Improved synchronization logic to check both enableUnpkg and enableSyncUnpkgFiles settings before proceeding.

Copy link
Contributor

coderabbitai bot commented May 14, 2024

Walkthrough

The recent update introduces a new configuration property enableSyncUnpkgFiles to control the synchronization of Unpkg files. The SyncPackageVersionFileEvent class now checks both enableUnpkg and enableSyncUnpkgFiles settings before proceeding with file synchronization. This change ensures more granular control over the synchronization process.

Changes

File Summary
app/core/event/SyncPackageVersionFile.ts Updated the syncPackageVersionFile method to check both enableUnpkg and enableSyncUnpkgFiles before syncing.
app/port/config.ts Added enableSyncUnpkgFiles property to CnpmcoreConfig type.
config/config.default.ts Added enableSyncUnpkgFiles: true to the default configuration settings.

In code we trust, with changes so bright,
Synchronizing files, in the moonlight,
With enableSyncUnpkgFiles, we now control,
Ensuring our packages, perfectly whole.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between cdca770 and c8440ff.
Files selected for processing (3)
  • app/core/event/SyncPackageVersionFile.ts (1 hunks)
  • app/port/config.ts (1 hunks)
  • config/config.default.ts (1 hunks)
Additional comments not posted (3)
app/core/event/SyncPackageVersionFile.ts (1)

19-21: Configuration check for enableSyncUnpkgFiles added.

app/port/config.ts (1)

148-151: New configuration property enableSyncUnpkgFiles added to CnpmcoreConfig.

config/config.default.ts (1)

56-56: Default value for enableSyncUnpkgFiles set to true.

@fengmk2 fengmk2 merged commit 101c9b3 into master May 14, 2024
10 of 11 checks passed
@fengmk2 fengmk2 deleted the fix-allow-to-disable-sync-unpkg-files branch May 14, 2024 06:46
fengmk2 pushed a commit that referenced this pull request May 14, 2024
[skip ci]

## [3.56.2](v3.56.1...v3.56.2) (2024-05-14)

### Bug Fixes

* allow to disable sync unpkg files ([#679](#679)) ([101c9b3](101c9b3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant