-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug/1798] Detect local helm if it was downloaded by the testsuite #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: denverwilliams <denver@debian.nz>
HashNuke
requested review from
denverwilliams,
wvwatson and
agentpoyo
as code owners
August 24, 2023 02:45
@HashNuke Appears the Chaos tests are failing with "zombie" errors. Did a re-run of failed jobs but the error looks like it might be a legit error, not github actions acting funny. |
@agentpoyo Oh yes - I just checked it. I think this is a legit issue. I will look into it. |
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: denverwilliams <denver@debian.nz>
Signed-off-by: denverwilliams <denver@debian.nz>
Signed-off-by: denverwilliams <denver@debian.nz>
Signed-off-by: Akash Manohar <akash@akash.im>
agentpoyo
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #1798
Description
Local helm was not being detected due to a bug in the helm shard (dependency). This was fixed in a recent PR to cnf-testsuite/helm#2.
This PR:
Below screenshot demonstrates the difference between the outputs of the
setup
command before and after the fix.How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue