Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug/1798] Detect local helm if it was downloaded by the testsuite #1819

Merged
merged 16 commits into from
Sep 7, 2023

Conversation

HashNuke
Copy link
Collaborator

Issues: #1798

Description

Local helm was not being detected due to a bug in the helm shard (dependency). This was fixed in a recent PR to cnf-testsuite/helm#2.

This PR:

  • Updates the helm shard dependency version.
  • Sets the corresponding ENV var for the helm shard to read the local helm path if it is set.

Below screenshot demonstrates the difference between the outputs of the setup command before and after the fix.

CleanShot 2023-08-24 at 09 39 40@2x

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@agentpoyo
Copy link
Collaborator

@HashNuke Appears the Chaos tests are failing with "zombie" errors. Did a re-run of failed jobs but the error looks like it might be a legit error, not github actions acting funny.

@HashNuke
Copy link
Collaborator Author

@agentpoyo Oh yes - I just checked it. I think this is a legit issue. I will look into it.

Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: Akash Manohar <akash@akash.im>
Signed-off-by: denverwilliams <denver@debian.nz>
Signed-off-by: denverwilliams <denver@debian.nz>
Signed-off-by: denverwilliams <denver@debian.nz>
Signed-off-by: Akash Manohar <akash@akash.im>
Copy link
Collaborator

@agentpoyo agentpoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agentpoyo agentpoyo merged commit 4c3e2f9 into main Sep 7, 2023
270 of 273 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants