Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reports: Add tarball hash #627

Closed
jayvdb opened this issue Aug 11, 2018 · 8 comments · Fixed by #689
Closed

reports: Add tarball hash #627

jayvdb opened this issue Aug 11, 2018 · 8 comments · Fixed by #689
Assignees
@KVGarg
Labels
difficulty/low importance/critical

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 11, 2018

The reports should include a tarball hash , as a variable in the yaml and this should be displayed beside the tarball in the HTML.

Mentors should check that the hash is correct before approving work reports.
@jayvdb jayvdb changed the title reports Add tarball hash reports: Add tarball hash Aug 11, 2018
@jayvdb
Copy link
Member Author

jayvdb commented Aug 11, 2018

It can be omitted for the 2017 reports ; we'll create another issue to record those

This was referenced Aug 11, 2018
Merged
Merged
Merged
Merged
Closed
@jayvdb
Copy link
Member Author

jayvdb commented Nov 6, 2018

As the hashes are already done for 2018 data, please compute the hashes for the 2017 files.

the field name we used was sha256sum iirc

@jayvdb jayvdb assigned jayvdb and KVGarg and unassigned jayvdb Nov 6, 2018
@KVGarg
Copy link
Contributor

KVGarg commented Nov 6, 2018

Ok, I understood what actually is to be done. I have to compute the hashes for 2017 files and display that computed hash on the webpage below the download link of the patch for all the reports (2018 and 2017)

@jayvdb
Copy link
Member Author

jayvdb commented Nov 6, 2018

yup; so the downloader can verify they have the correct file, and the tarball (which isnt hosted on coala servers) hasnt been modified since the report was approved and merged.

@KVGarg
Copy link
Contributor

KVGarg commented Nov 7, 2018 •
edited
Loading

I managed to calculate the hash values for 2017 report files and display those hash values on webpage for all reports, but while displaying the hash value in the Patch Tarball card-view, it was increasing the size of other cards that were opposite to that card. I have attached the screenshot, please check that.
original
To avoid this thing, I have designed 3 designs - please have a look at them and tell me which design will look good on page. or you want me to make any other custom design ?

  1. Design-1

design-1
2. Design-2
design-2
3. Design-3
design-3

Also there is margin right to the Mentor's card, but not being shown up in screenshot

@KVGarg
Copy link
Contributor

KVGarg commented Nov 7, 2018 •
edited
Loading

Hi @jayvdb ,I want to ask one more thing while working on this issue I have changed 9 files( 8 report files and 1 HTML file) so should I commit these files separately or together ?

@li-boxuan
Copy link
Member

@KVGarg Commit them together.

@KVGarg
Copy link
Contributor

KVGarg commented Nov 8, 2018

For now I'm committing with changes in default design :-)

KVGarg added a commit to KVGarg/projects that referenced this issue Nov 8, 2018
@KVGarg
reports: Display sha256sum on webpage
bb14c06 
As per issue, I have added the computed sha256sum hash values for
patch tarball for all the 2017 report files and display them on the
project report webpage.

Closes coala#627
@KVGarg KVGarg mentioned this issue Nov 8, 2018
Merged
2 tasks
KVGarg added a commit to KVGarg/projects that referenced this issue Nov 9, 2018
@KVGarg
reports: Display sha256sum on webpage
f8a11ba 
As per issue, I have added the computed sha256sum hash values for
patch tarball for all the 2017 report files and display them on the
project report webpage.
Only a part of hash value(first 7 characters only) is displayed on
the webpage instead of entire hash value and a `copy to clipboard`
button is added beside that hash value which will copy the entire
hash value to the clipboard.
and Removed some of space inconsistencies mentioned in travis tests.

Closes coala#627
gitmate-bot pushed a commit to KVGarg/projects that referenced this issue Nov 11, 2018
@KVGarg @gitmate-bot
reports: Display sha256sum on webpage
043a1db 
As per issue, I have added the computed sha256sum hash values for
patch tarball for all the 2017 report files and display them on the
project report webpage.
Only a part of hash value(first 7 characters only) is displayed on
the webpage instead of entire hash value and a `copy to clipboard`
button is added beside that hash value which will copy the entire
hash value to the clipboard.
and Removed some of space inconsistencies mentioned in travis tests.

Closes coala#627
KVGarg added a commit to KVGarg/projects that referenced this issue Nov 11, 2018
@KVGarg
reports: Display sha256sum on webpage
a138041 
As per issue, I have added the computed sha256sum hash values for
patch tarball for all the 2017 report files and display them on the
project report webpage.
Only a part of hash value(first 7 characters only) is displayed on
the webpage instead of entire hash value and a `copy to clipboard`
button is added beside that hash value which will copy the entire
hash value to the clipboard.
and Removed some of space inconsistencies mentioned in travis tests.
Formatted `style.css` by alpha ordering of properties. Maintained
single quotes consistency in new Javascript code added.
Closes coala#627
KVGarg added a commit to KVGarg/projects that referenced this issue Nov 11, 2018
@KVGarg
reports: Display sha256sum on webpage
78553b0 
As per issue, I have added the computed sha256sum hash values for
patch tarball for all the 2017 report files and display only the
first seven characters of computed  hash value on the project report
webpage and the user can copy the full hash value by clicking on
`clipboard` icon.

Closes coala#627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KVGarg KVGarg

Labels
difficulty/low importance/critical
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reports: Display sha256sum on webpage KVGarg/projects
3 participants
@jayvdb @li-boxuan @KVGarg