Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GSoC report link for completed tasks #714

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KVGarg
Copy link
Contributor

@KVGarg KVGarg commented Feb 17, 2019

This commit adds the corresponding GSoC report
link for completed tasks.

Closes #703

Checklist

  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

@TravisBuddy

This comment has been minimized.

@KVGarg KVGarg force-pushed the link-to-report-for-completed-tasks branch 2 times, most recently from c278130 to f12dc75 Compare February 17, 2019 17:59
@TravisBuddy

This comment has been minimized.

@TravisBuddy
Copy link

Travis tests have failed

Hey @KVGarg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci
Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][18:02:36] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/partials/tabs/projects.html
|    |++++| /app/partials/tabs/projects.html
|  61|  61|           <div class="small-heading uppercase">Initiatives</div> <span class="chip" ng-repeat="initiative in currentProject.initiatives">{{ initiative }}</span>
|  62|  62|           <br> </div>
|  63|  63|         <div ng-show="currentProject.report.length>0">
|  64|    |-          <div class="small-heading uppercase">GSoC</div> 
|    |  64|+          <div class="small-heading uppercase">GSoC</div>
|  65|  65|           <span class="chip gsoc-report" ng-click="redirectToReport()">Report</span>
|  66|  66|         </div>
|  67|  67|         <div ng-show="currentProject.collaborating_projects.length>0">
[INFO][18:02:38] Applied 'ShowPatchAction' on 'partials/tabs/projects.html' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][18:02:38] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][18:02:38] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][18:02:38] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][18:02:38] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][18:02:38] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][18:02:38] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
Executing section html...
[WARNING][18:02:39] HTMLLintBear: This result has no patch attached.

partials/tabs/projects.html
|  64| ··········<div·class="small-heading·uppercase">GSoC</div>·
|    | [MAJOR] HTMLLintBear:
|    | Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.
Executing section yml...
Executing section new_linelength_projects...
Executing section old_linelength_projects...
Executing section cli...
nothing changed, not updating cache


Done. Your build exited with 1.
TravisBuddy Request Identifier: 399b7a50-32de-11e9-909a-37b9af0e35d8

Copy link
Contributor

@frextrite frextrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report section is not showing up in the project details popup. Have a look at it.

@KVGarg
Copy link
Contributor Author

KVGarg commented Feb 18, 2019

@frextrite not all completed projects are having report section on the LHS. Only few of completed projects, around 22 completed projects are having that section.
You can find it below initiatives, having a title of GSoC for completed projects.
3c83872c-b4e2-4c9c-a3a7-d62e1649794f

@frextrite
Copy link
Contributor

My bad. Can see them now. I was looking for the report link in the uncompleted projects.

@frextrite
Copy link
Contributor

Sidenote: You may want to check everything in the checklist

Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

_projects/antlr-v4.md Outdated Show resolved Hide resolved
resources/js/app.js Outdated Show resolved Hide resolved
@TravisBuddy
Copy link

Travis tests have failed

Hey @KVGarg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci
Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][11:16:54] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][11:16:57] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][11:16:57] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/README.md
|    |++++| /app/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][11:16:57] Applied 'ShowPatchAction' on 'README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  34|  34| 1. Install [asdf-vm](https://asdf-vm.github.io/asdf/#/core-manage-asdf-vm) for your OS.
|  35|  35| 2. Using asdf-vm, install [ruby](https://github.com/asdf-vm/asdf-ruby).
|  36|  36| 3. Install Jekyll
|  37|    |-    
|    |  37|+
|  38|  38|         $ gem install jekyll bundler
|  39|  39| 
|  40|  40| ### Clone and Run
[INFO][11:16:57] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  40|  40| ### Clone and Run
|  41|  41| 
|  42|  42| Clone coala Projects repository
|  43|    |-    
|    |  43|+
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|  45|     
|  46|  46| Run coala Projects website
[INFO][11:16:57] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/data/locale/en/README.md
|    |++++| /app/data/locale/en/README.md
|  42|  42| Clone coala Projects repository
|  43|  43|     
|  44|  44|     $ git clone https://github.com/coala/projects.git
|  45|    |-    
|    |  45|+
|  46|  46| Run coala Projects website
|  47|  47| 
|  48|  48|     $ cd projects
[INFO][11:16:57] Applied 'ShowPatchAction' on 'data/locale/en/README.md' from 'SpaceConsistencyBear'.
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - Trailing whitespaces.
|----|    | /app/partials/tabs/projects.html
|    |++++| /app/partials/tabs/projects.html
|  61|  61|           <div class="small-heading uppercase">Initiatives</div> <span class="chip" ng-repeat="initiative in currentProject.initiatives">{{ initiative }}</span>
|  62|  62|           <br> </div>
|  63|  63|         <div ng-show="currentProject.report.length>0">
|  64|    |-          <div class="small-heading uppercase">GSoC</div> 
|    |  64|+          <div class="small-heading uppercase">GSoC</div>
|  65|  65|           <span class="chip gsoc-report" ng-click="redirectToReport()">Report</span>
|  66|  66|         </div>
|  67|  67|         <div ng-show="currentProject.collaborating_projects.length>0">
[INFO][11:16:57] Applied 'ShowPatchAction' on 'partials/tabs/projects.html' from 'SpaceConsistencyBear'.
Executing section html...
[WARNING][11:16:57] HTMLLintBear: This result has no patch attached.

partials/tabs/projects.html
|  64| ··········<div·class="small-heading·uppercase">GSoC</div>·
|    | [MAJOR] HTMLLintBear:
|    | Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.
Executing section yml...
Executing section cli...
TravisBuddy Request Identifier: b5f860d0-3825-11e9-b76d-d9638afbe879

@KVGarg KVGarg force-pushed the link-to-report-for-completed-tasks branch from 48929e5 to 6ac493a Compare August 22, 2019 14:38
@TravisBuddy
Copy link

Travis tests have failed

Hey @KVGarg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7db4fd10-c4ec-11e9-8712-75d78f9b457f

@KVGarg KVGarg force-pushed the link-to-report-for-completed-tasks branch from 6ac493a to 6b94da2 Compare August 22, 2019 15:03
@jayvdb
Copy link
Member

jayvdb commented Aug 24, 2019

These links should be derived from the other metadata. DRY.
If necessary, the links can be built in jekyll before being served for the frontend to use.

@KVGarg
Copy link
Contributor Author

KVGarg commented Aug 24, 2019

So, we should get work report based on project tile because it is the only common thing that can be there between a project and a work report, right?

@KVGarg KVGarg force-pushed the link-to-report-for-completed-tasks branch from 6b94da2 to 7067dc8 Compare August 25, 2019 13:18
@KVGarg KVGarg force-pushed the link-to-report-for-completed-tasks branch from 7067dc8 to 05f8057 Compare August 25, 2019 13:25
@KVGarg
Copy link
Contributor Author

KVGarg commented Aug 25, 2019

The current preview is displaying reports option on project popup, only if the project name is same as that in report 😞

@KVGarg KVGarg force-pushed the link-to-report-for-completed-tasks branch from 05f8057 to 74b70b4 Compare August 25, 2019 14:20
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a GSoC report was found, the list of initiatives is no longer valid if it contained items other than GSoC, and doesnt need to be shown as it is wasting space at the top of the UI.

Partial matching isnt acceptable. Old data needs to be grand-fathered in.

Please add an extra commit, or add a PR based on top of this one, which matches the reports for all GSoC projects, and removes the old initiatives. You can change titles , etc, or add extra attributes to be able to join report to project. But old URLs must not be broken, so any URL change needs a redirect added, either using netlify redirects or redirects built using jekyll or redirects built in ng.

@KVGarg KVGarg force-pushed the link-to-report-for-completed-tasks branch 2 times, most recently from 0c0c445 to 53e114f Compare August 26, 2019 11:27
@KVGarg KVGarg changed the title Add GSoC report link for completed tasks Add GSoC report link for completed tasks [WIP] Aug 26, 2019
This commit adds the corresponding GSoC report
link for completed tasks.

Closes coala#703
@KVGarg
Copy link
Contributor Author

KVGarg commented Aug 26, 2019

For these two projects I wasn't able to find reports:

  1. Documentation Extraction and Parsing
  2. Extend Linter Integration

else i found all reports and added a new attribute to projects *.md files named improved_title which consists of the value of project name corresponding to the report!
If any GSoCer changes the default project name, the user will have to add this new attr to project having the new name of the project from there report!

The commit adds the new title for all those completed
projects who got a new and a suitable title during the
program. As the student starts working on project, user
get to know "what will the be the most suitable title for
the project?" and uses that in the work report too. So,
add all such titles from reports to there corresponding
projects.
Also, this change will allow us to display the student work
report itself on the project popup.
@KVGarg KVGarg force-pushed the link-to-report-for-completed-tasks branch from 53e114f to f3fa76c Compare August 26, 2019 19:20
@KVGarg KVGarg changed the title Add GSoC report link for completed tasks [WIP] Add GSoC report link for completed tasks Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add link to corresponding GSoC report for finished task
6 participants