Add GSoC report link for completed tasks #714
Open
+65
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
KVGarg
force-pushed
the
link-to-report-for-completed-tasks
branch
2 times, most recently
from
c278130
to
f12dc75
Compare
This comment has been minimized.
This comment has been minimized.
Travis tests have failedHey @KVGarg, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: 399b7a50-32de-11e9-909a-37b9af0e35d8 |
frextrite
suggested changes
Feb 18, 2019
|
@frextrite not all completed projects are having report section on the LHS. Only few of completed projects, around 22 completed projects are having that section. |
|
My bad. Can see them now. I was looking for the report link in the uncompleted projects. |
frextrite
approved these changes
Feb 18, 2019
|
Sidenote: You may want to check everything in the checklist |
KVGarg
force-pushed
the
link-to-report-for-completed-tasks
branch
from
f12dc75
to
48929e5
Compare
Travis tests have failedHey @KVGarg, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ciTravisBuddy Request Identifier: b5f860d0-3825-11e9-b76d-d9638afbe879 |
KVGarg
force-pushed
the
link-to-report-for-completed-tasks
branch
from
48929e5
to
6ac493a
Compare
Travis tests have failedHey @KVGarg, TravisBuddy Request Identifier: 7db4fd10-c4ec-11e9-8712-75d78f9b457f |
KVGarg
force-pushed
the
link-to-report-for-completed-tasks
branch
from
6ac493a
to
6b94da2
Compare
|
These links should be derived from the other metadata. DRY. |
|
So, we should get work report based on project tile because it is the only common thing that can be there between a project and a work report, right? |
KVGarg
force-pushed
the
link-to-report-for-completed-tasks
branch
from
6b94da2
to
7067dc8
Compare
KVGarg
force-pushed
the
link-to-report-for-completed-tasks
branch
from
7067dc8
to
05f8057
Compare
|
The current preview is displaying reports option on project popup, only if the project name is same as that in report 😞 |
KVGarg
force-pushed
the
link-to-report-for-completed-tasks
branch
from
05f8057
to
74b70b4
Compare
jayvdb
requested changes
Aug 25, 2019
There was a problem hiding this comment.
If a GSoC report was found, the list of initiatives is no longer valid if it contained items other than GSoC, and doesnt need to be shown as it is wasting space at the top of the UI.
Partial matching isnt acceptable. Old data needs to be grand-fathered in.
Please add an extra commit, or add a PR based on top of this one, which matches the reports for all GSoC projects, and removes the old initiatives. You can change titles , etc, or add extra attributes to be able to join report to project. But old URLs must not be broken, so any URL change needs a redirect added, either using netlify redirects or redirects built using jekyll or redirects built in ng.
KVGarg
force-pushed
the
link-to-report-for-completed-tasks
branch
2 times, most recently
from
0c0c445
to
53e114f
Compare
KVGarg
changed the title
This commit adds the corresponding GSoC report link for completed tasks. Closes coala#703
|
For these two projects I wasn't able to find reports:
else i found all reports and added a new attribute to |
The commit adds the new title for all those completed projects who got a new and a suitable title during the program. As the student starts working on project, user get to know "what will the be the most suitable title for the project?" and uses that in the work report too. So, add all such titles from reports to there corresponding projects. Also, this change will allow us to display the student work report itself on the project popup.
KVGarg
force-pushed
the
link-to-report-for-completed-tasks
branch
from
53e114f
to
f3fa76c
Compare
KVGarg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the corresponding GSoC report
link for completed tasks.
Closes #703
Checklist
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!