Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support IPv6 with interface #128

Merged
merged 1 commit into from
Oct 21, 2021
Merged

fix: Support IPv6 with interface #128

merged 1 commit into from
Oct 21, 2021

Conversation

gerdemann
Copy link
Member

Resolves: #73

@gerdemann gerdemann mentioned this pull request Oct 20, 2021
Closed
JKRhb
JKRhb approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with local device using CoAP and it seems to work :) Thank you for this fix! uri-js seems much better than the native URL constructor :)

@gerdemann gerdemann merged commit 8fc1c1b into main Oct 21, 2021
@gerdemann gerdemann deleted the bugfix/ipv6-interface branch October 21, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKRhb JKRhb JKRhb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot set property 'method' of undefined
2 participants
@gerdemann @JKRhb