Update @types/react-dom to fix CI status #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fand
force-pushed
the
update-types-react-dom
branch
from
2c9197c
to
6be1f43
Compare
|
aha, we must remove package-lock.json and use yarn on CircleCI... |
|
@bcherny Any ETA for this to be merged and published to npm as |
|
@fand @toqueteos Sorry for sleeping on this. I merged #53 instead - it is a better fix I think.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
masterdoesn't pass the test because@types/react-dom@16.0.0doesn't work well with@types/react@16.0.0.I looked build logs on Circle CI and found
greenkeeper/@types/react-dom-16.0.1passed the test, so I updated@types/react-domto 16.0.1.https://circleci.com/gh/coatue-oss/react2angular
Also I edited circle.yml to use
yarnin CircleCI instead ofnpm install.I removed
package-lock.jsonbecause it was in inconsistent state withyarn.lock.