Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "cobbler mkloaders" view #260

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Add "cobbler mkloaders" view #260

merged 2 commits into from
Jul 19, 2024

Conversation

00Kadie00
Copy link
Contributor

for issue #48

added view for mkloaders

@github-actions github-actions bot added API-Client Project cobbler-client Frontend Project cobbler-frontend labels Jul 19, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 17.12%. Comparing base (f57e46e) to head (d12086c).
Report is 54 commits behind head on main.

Files Patch % Lines
...rojects/cobbler-api/src/lib/cobbler-api.service.ts 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (f57e46e) and HEAD (d12086c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f57e46e) HEAD (d12086c)
unit-cobbler-frontend 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   25.80%   17.12%   -8.68%     
==========================================
  Files          45        7      -38     
  Lines        1461     1238     -223     
  Branches      437      429       -8     
==========================================
- Hits          377      212     -165     
+ Misses       1064     1000      -64     
- Partials       20       26       +6     
Flag Coverage Δ
unit-cobbler-api 7.19% <0.00%> (+2.75%) ⬆️
unit-cobbler-frontend ?
unit-typescript-xmlrpc 62.05% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchoolGuy SchoolGuy added this to the V0.0.1 milestone Jul 19, 2024
@SchoolGuy SchoolGuy self-requested a review July 19, 2024 18:54
@SchoolGuy SchoolGuy changed the title add mkloaders view Add "cobbler mkloaders" view Jul 19, 2024
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy linked an issue Jul 19, 2024 that may be closed by this pull request
@SchoolGuy SchoolGuy merged commit 82add66 into main Jul 19, 2024
11 checks passed
@SchoolGuy SchoolGuy deleted the mkloaders branch July 19, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-Client Project cobbler-client Frontend Project cobbler-frontend
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement page for cobbler mkloaders
3 participants