Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobbler-Frontend: Implement Settings CRUD #89

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Conversation

SchoolGuy
Copy link
Member

@SchoolGuy SchoolGuy commented Jun 21, 2022

Fixes #51

TODO:

@SchoolGuy SchoolGuy added this to the V0.0.1 milestone Jun 21, 2022
@github-actions github-actions bot added the Frontend Project cobbler-frontend label Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #89 (3d70a7b) into main (71b7643) will increase coverage by 2.86%.
The diff coverage is 58.20%.

❗ Current head 3d70a7b differs from pull request most recent head aef2894. Consider uploading reports for the commit aef2894 to get more accurate results

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   22.93%   25.80%   +2.86%     
==========================================
  Files          42       45       +3     
  Lines        1417     1461      +44     
  Branches      432      437       +5     
==========================================
+ Hits          325      377      +52     
+ Misses       1075     1064      -11     
- Partials       17       20       +3     
Flag Coverage Δ
unit-cobbler-api 4.44% <77.77%> (+1.61%) ⬆️
unit-cobbler-frontend 72.42% <51.02%> (+5.89%) ⬆️
unit-typescript-xmlrpc 61.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/app/settings/view/settings-view.component.ts 37.50% <37.50%> (ø)
...frontend/src/app/services/item-settings.service.ts 50.00% <42.85%> (ø)
...pp/common/viewable-tree/viewable-tree.component.ts 56.52% <56.52%> (ø)
...rojects/cobbler-api/src/lib/cobbler-api.service.ts 4.26% <77.77%> (+1.62%) ⬆️
projects/cobbler-frontend/src/app/app.component.ts 100.00% <100.00%> (+80.00%) ⬆️
...pp/common/editable-tree/editable-tree.component.ts 100.00% <100.00%> (ø)
...d/src/app/settings/edit/settings-edit.component.ts 100.00% <100.00%> (ø)
...er-frontend/src/app/services/auth-guard.service.ts 17.24% <0.00%> (+6.89%) ⬆️
.../cobbler-frontend/src/app/services/user.service.ts 65.00% <0.00%> (+30.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b7643...aef2894. Read the comment docs.

@github-actions github-actions bot added API-Client Project cobbler-client TS-XMLRPC Project typescript-xmlrpc labels Jun 21, 2022
@SchoolGuy SchoolGuy force-pushed the implement-settings branch 3 times, most recently from 348e253 to 9ad9849 Compare June 26, 2022 13:50
@SchoolGuy
Copy link
Member Author

The fix for the tests that the missing modules are imported should be split out tomorrow.

@SchoolGuy SchoolGuy force-pushed the implement-settings branch 2 times, most recently from 02fbb22 to 8c0b3b3 Compare June 27, 2022 08:54
@SchoolGuy
Copy link
Member Author

I made huge progress for multiple things but I am not yet ready to commit something today. I have feedback from @agraul what I can improve and this is what I will try to focus on tomorrow.

@github-actions github-actions bot removed the TS-XMLRPC Project typescript-xmlrpc label Jun 28, 2022
@SchoolGuy
Copy link
Member Author

I will try to address the remaining open points and clean the git history before I will merge this PR.

This commit is currently incomplete as it does only define the margin for one
device type (600-904px).

The details have to be implemented at a later point according to:
https://material.io/design/layout/understanding-layout.html#layout-anatomy
@SchoolGuy SchoolGuy force-pushed the implement-settings branch 2 times, most recently from 4732226 to e3465af Compare June 28, 2022 14:47
@SchoolGuy SchoolGuy marked this pull request as ready for review June 28, 2022 16:33
@SchoolGuy SchoolGuy merged commit 7d3f0c9 into main Jun 28, 2022
@SchoolGuy SchoolGuy deleted the implement-settings branch June 28, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-Client Project cobbler-client Frontend Project cobbler-frontend
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement page to view cobbler setting
1 participant